Date: Sat, 12 Mar 2016 16:17:20 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        "Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
        Andy Lutomirski <luto@amacapital.net>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>, Fenghua Yu <fenghua.yu@intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Oleg Nesterov <oleg@redhat.com>,
        "Yu, Yu-cheng" <yu-cheng.yu@intel.com>
Subject: Re: [PATCH] x86/FPU: Fix FPU handling on legacy FPU machines
Message-ID: <20160312151720.GB7015@gmail.com>
References: <CAHp75Vep=e3HWHHJh-Z6Q9yr8dik715ctbthABxf2Grbuf7jow@mail.gmail.com>
 <20160310145940.GB26708@pd.tnic>
 <CALCETrW5_GfXYCgocmESHf3G-2RWmhmc-+81fX0eDxFH5vu3VQ@mail.gmail.com>
 <20160311090840.GA8486@gmail.com>
 <20160311094802.GA4312@pd.tnic>
 <1457694124.2007.12.camel@nexus-software.ie>
 <20160311112610.GC4312@pd.tnic>
 <20160311113206.GD4312@pd.tnic>
 <CA+55aFyHQ0+zM5pBNWakA_ti4gutLX5VdounyuduGeFGTmvksg@mail.gmail.com>
 <20160311220313.GG4312@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160311220313.GG4312@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1133
Lines: 33


* Borislav Petkov <bp@alien8.de> wrote:

> On Fri, Mar 11, 2016 at 10:32:43AM -0800, Linus Torvalds wrote:
> > Obvious Ack to the patch, along with a "how did this ever work
> > before?" comment..
> 
> I had a sarcastic sentence in the commit message which I deleted later:
> 
> "Apparently no one had tried the kernel on a 486er after the FPU
> rewrite. Backwards compatibility is overrated."
> 
> :-)
> 
> I'm still wondering, though, why didn't the Quark people scream
> earlier... And who knows, it was probably b0rked even before the
> FPU rewrite.

So I actually tested legacy FPU support during (and after) the big FPU rewrite - I 
even tried FPU emu and we made that work (it was broken for like years).

This particular breakage was made prominent recently, with switching old FPU CPUs 
over to eagerfpu context switching:

  58122bf1d856 x86/fpu: Default eagerfpu=on on all CPUs

If you check the fix, it only affects eagerfpu code paths. So to see the bug with 
Quark (or ancient CPUs) you'd have to have booted it with eagerfpu=on - and most 
people avoid twiddling boot parameters if they can avoid it.

Thanks,

	Ingo