Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753396AbcCLPUl (ORCPT ); Sat, 12 Mar 2016 10:20:41 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:34999 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbcCLPUf (ORCPT ); Sat, 12 Mar 2016 10:20:35 -0500 From: Nicolai Stange To: Nicolai Stange Cc: Greg Kroah-Hartman , Rasmus Villemoes , linux-kernel@vger.kernel.org Subject: Re: [PATCH] debugfs: fix double unlock in open_proxy_open() References: <1457795345-23014-1-git-send-email-nicstange@gmail.com> Date: Sat, 12 Mar 2016 16:20:31 +0100 In-Reply-To: <1457795345-23014-1-git-send-email-nicstange@gmail.com> (Nicolai Stange's message of "Sat, 12 Mar 2016 16:09:05 +0100") Message-ID: <87pouzafk0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 383 Lines: 15 Nicolai Stange writes: > In case an open is racing with a debugfs file removal, the corresponding > error path in open_proxy_open() releases its SRCU read side critical > section twice, i.e. it does a double unlock. This one has been reported by Rasmus Villemoes: http://lkml.kernel.org/g/87d1r2uh95.fsf@rasmusvillemoes.dk Thank you very much! Nicolai