Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753452AbcCLQOn (ORCPT ); Sat, 12 Mar 2016 11:14:43 -0500 Received: from mga11.intel.com ([192.55.52.93]:37033 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752421AbcCLQOd convert rfc822-to-8bit (ORCPT ); Sat, 12 Mar 2016 11:14:33 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,325,1455004800"; d="scan'208";a="935466646" From: "Luck, Tony" To: Peter Zijlstra CC: Vikas Shivappa , "Shivappa, Vikas" , "linux-kernel@vger.kernel.org" , "x86@kernel.org" , "hpa@zytor.com" , "tglx@linutronix.de" , "mingo@kernel.org" , "Shankar, Ravi V" , "Yu, Fenghua" , "Anvin, H Peter" Subject: RE: [PATCH V6 0/6] Intel memory b/w monitoring support Thread-Topic: [PATCH V6 0/6] Intel memory b/w monitoring support Thread-Index: AQHReyUvAfqQDFPIP0W/+ML4ezpFBp9VYb+A//+FFJCAACWG8IAA6+2AgAAEyDA= Date: Sat, 12 Mar 2016 16:14:17 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F3A0076FF@ORSMSX114.amr.corp.intel.com> References: <1457652732-4499-1-git-send-email-vikas.shivappa@linux.intel.com> <20160311225427.GG6344@twins.programming.kicks-ass.net> <3908561D78D1C84285E8C5FCA982C28F3A00723E@ORSMSX114.amr.corp.intel.com> <20160312075313.GH6344@twins.programming.kicks-ass.net> In-Reply-To: <20160312075313.GH6344@twins.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTFiYzM1N2YtMTVkYy00ZDVhLWE0YzEtNTc0NzZhY2VjZDkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkFCWEpRUVJQWDdITlpHNGtcLzZTUzRUTUFHdUFkVVp5TTRaa1k2SzZGYkFrPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 553 Lines: 16 >> There are a few good calls, then I see rmid=-380863112 evt_type=-30689 first=0 >> >> That turns into a wild vrmid, and we fault accessing mbm_current->prev_msr > > It's because I'm a right idiot.. The below should sort that methinks. Tsk tsk ... don't insult the coder, just critique the code :-) > Will push a new branch Pulled the new branch ... seems to be working fine now. Is the series good now (i.e. on a trajectory to be merged when Linus opens the 4.6 window)? Or is there anything else that anyone would like to see cleaned up? -Tony