MIME-Version: 1.0
In-Reply-To: <20160311222023.GH4312@pd.tnic>
References: <20160310145940.GB26708@pd.tnic> <CALCETrW5_GfXYCgocmESHf3G-2RWmhmc-+81fX0eDxFH5vu3VQ@mail.gmail.com>
 <20160311090840.GA8486@gmail.com> <20160311094802.GA4312@pd.tnic>
 <1457694124.2007.12.camel@nexus-software.ie> <20160311112610.GC4312@pd.tnic>
 <20160311113206.GD4312@pd.tnic> <CA+55aFyHQ0+zM5pBNWakA_ti4gutLX5VdounyuduGeFGTmvksg@mail.gmail.com>
 <20160311220313.GG4312@pd.tnic> <56E34197.8080209@linux.intel.com> <20160311222023.GH4312@pd.tnic>
From: Andy Lutomirski <luto@amacapital.net>
Date: Sat, 12 Mar 2016 09:21:16 -0800
Message-ID: <CALCETrXFDtZ9qkyaPTNqos+=Q8iDSxbjaC36ikg5dJBc8+sToA@mail.gmail.com>
Subject: Re: [PATCH] x86/FPU: Fix FPU handling on legacy FPU machines
To: Borislav Petkov <bp@alien8.de>
Cc: Fenghua Yu <fenghua.yu@intel.com>, Thomas Gleixner <tglx@linutronix.de>,
        "x86@kernel.org" <x86@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Bryan O'Donoghue" <pure.logic@nexus-software.ie>,
        Andrew Morton <akpm@linux-foundation.org>,
        Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "Yu, Yu-cheng" <yu-cheng.yu@intel.com>,
        Linus Torvalds <torvalds@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1001
Lines: 23

On Mar 11, 2016 2:20 PM, "Borislav Petkov" <bp@alien8.de> wrote:
>
> On Fri, Mar 11, 2016 at 02:07:19PM -0800, Dave Hansen wrote:
> > I've actually got 4.0 running on my Quark board.  The FPU rewrite
> > dropped in just after that iirc.
>
> 4.2 or so... Ok, so it looks like we broke it then.
>

For reference, what are the QEMU options and boot options you used to
trigger this?  I'm asking because I tested eagerfpu=on without fxsr a
few weeks ago in QEMU, and I didn't trigger it.  Maybe I needed to
force KVM off or something.  Off the top of my head, I'm guessing that
when I wrote "x86/fpu: Fix FNSAVE usage in eagerfpu mode", I was
inadvertently using a bastardize combination of FNSAVE and
FXRSTOR-of-init-state, KVM let the FXRSTOR through despite not
advertising it in CPUID, and it papered over the init issue because
the wrong init state format was hidden by using the wrong instruction
to load it.

Sigh.  Yet more reason for Intel to add chicken bits to *turn off* new features.

--Andy