Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753556AbcCLRef (ORCPT ); Sat, 12 Mar 2016 12:34:35 -0500 Received: from mail-yw0-f173.google.com ([209.85.161.173]:33626 "EHLO mail-yw0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbcCLRee (ORCPT ); Sat, 12 Mar 2016 12:34:34 -0500 MIME-Version: 1.0 In-Reply-To: <20160311220009.GC11274@kroah.com> References: <1457034046-27678-5-git-send-email-gustavo@padovan.org> <1457044963-5785-1-git-send-email-gustavo@padovan.org> <20160311220009.GC11274@kroah.com> Date: Sat, 12 Mar 2016 12:34:33 -0500 Message-ID: Subject: Re: [PATCH] staging/android: change IOCTLs opcode after ABI change From: Rob Clark To: Gustavo Padovan Cc: Linux Kernel Mailing List , Greg Kroah-Hartman , devel@driverdev.osuosl.org, "dri-devel@lists.freedesktop.org" , Daniel Stone , =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= , Riley Andrews , Daniel Vetter , Greg Hackmann , John Harrison , Maarten Lankhorst , Gustavo Padovan , John Stultz , Rob Herring Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1615 Lines: 44 On Fri, Mar 11, 2016 at 5:00 PM, Greg Kroah-Hartman wrote: > On Thu, Mar 03, 2016 at 07:42:43PM -0300, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Burn the old opcode to avoid any potential old userspace running the old >> API to get weird errors. Changing the opcodes will make them fail right >> away. >> >> This is just a precaution, there no upstream users of these interfaces >> yet and the only user is Android, but we don't expect anyone trying to >> run android userspace and all it dependencies on top of upstream kernels. >> >> Moreover Android should be converted to use upstream sync_files. >> >> Suggested-by: Rob Clark >> Signed-off-by: Gustavo Padovan >> --- >> drivers/staging/android/uapi/sync.h | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) > > Where does this belong in this patch series? Before it? After it? In > the middle? Not sure if overkill, but if we wanted to be pedantic about bisectability put all the uabi struct changes plus ioctl # changes into a single patch (with the following patches starting to use the new fields)? Either way, I think the only two people in the world effected by this (ie. who are playing with AOSP on an upstream (plus a few patches) kernel) are Rob Herring and John Stultz. (Adding them to CC so they are aware). BR, -R > Please resend the whole series, gather up all of the reviewed and > signed-off-by markings from everyone involved, and I'll be glad to apply > them. > > thanks, > > greg k-h