Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753874AbcCMAo7 (ORCPT ); Sat, 12 Mar 2016 19:44:59 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:50721 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753561AbcCMAov (ORCPT ); Sat, 12 Mar 2016 19:44:51 -0500 Date: Sat, 12 Mar 2016 16:27:29 -0800 From: Greg KH To: Nicolas Saenz Julienne Cc: oliver@neukum.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: cdc-acm: add support for Sagem Monetel ELC930 Message-ID: <20160313002729.GA4420@kroah.com> References: <1457826291-5204-1-git-send-email-nicolassaenzj@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457826291-5204-1-git-send-email-nicolassaenzj@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 834 Lines: 24 On Sat, Mar 12, 2016 at 11:44:51PM +0000, Nicolas Saenz Julienne wrote: > Signed-off-by: Nicolas Saenz Julienne > --- > drivers/usb/class/cdc-acm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c > index fa4e239..9831607 100644 > --- a/drivers/usb/class/cdc-acm.c > +++ b/drivers/usb/class/cdc-acm.c > @@ -1681,6 +1681,9 @@ static const struct usb_device_id acm_ids[] = { > { USB_DEVICE(0x079b, 0x000f), /* BT On-Air USB MODEM */ > .driver_info = NO_UNION_NORMAL, /* has no union descriptor */ > }, > + { USB_DEVICE(0x079b, 0x0088), /* SAGEM Monetel ELC930 */ > + .driver_info = NO_UNION_NORMAL, /* has no union descriptor */ > + }, Why is this needed? Does the descriptors not properly set the class device? thanks, greg k-h