MIME-Version: 1.0
In-Reply-To: <20160312171648.GA12167@gmail.com>
References: <a44e1055efc2d2a9473307b22c91caa437aa3f8b.1456439214.git.tony.luck@intel.com>
	<56E1CA7B.5040706@nextfour.com>
	<3908561D78D1C84285E8C5FCA982C28F3A005009@ORSMSX114.amr.corp.intel.com>
	<CA+8MBbKn5DU22RHPYR=vKWpKd1aBu4dm5p57R5U5WTb7KCpMVQ@mail.gmail.com>
	<20160312171648.GA12167@gmail.com>
Date: Sat, 12 Mar 2016 17:12:38 -0800
Message-ID: <CA+55aFxQQsmy0wQrQeFPp_+M=y0qwyH8w3irij7RdcSREdWUzA@mail.gmail.com>
Subject: Re: [PATCH v14] x86, mce: Add memcpy_mcsafe()
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Tony Luck <tony.luck@gmail.com>,
        =?UTF-8?Q?Mika_Penttil=C3=A4?= <mika.penttila@nextfour.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>,
        "Williams, Dan J" <dan.j.williams@intel.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 554
Lines: 14

On Sat, Mar 12, 2016 at 9:16 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> Please use the copy_*_user() memory copying API semantics, which are: return
> negative code (-EFAULT) on error, 0 on success.

Those are the get_user/put_user() semantics.

copy_*_user() has those annoying "bytes left uncopied" return values
that I really wouldn't encourage anybody else use unless they really
have to.  There are (good) reasons why it's done that way, but it's
still not something that should be aped without the same kind of major
reasons.

            Linus