Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932481AbcCMJNu (ORCPT <rfc822;w@1wt.eu>);
	Sun, 13 Mar 2016 05:13:50 -0400
Received: from www.linutronix.de ([62.245.132.108]:42808 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932090AbcCMJNo (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 13 Mar 2016 05:13:44 -0400
Date: Sun, 13 Mar 2016 10:11:57 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Jianyu Zhan <nasa4836@gmail.com>
cc: mingo@redhat.com, "H. Peter Anvin" <hpa@zytor.com>,
        Aravind.Gopalakrishnan@amd.com, brgerst@gmail.com, bp@suse.de,
        feng.wu@intel.com, jiang.liu@linux.intel.com,
        Tejun Heo <tj@kernel.org>, dvlasenk@redhat.com, penberg@cs.helsinki.fi,
        Yinghai Lu <yhlu.kernel@gmail.com>, andi@firstfloor.org,
        Andy Lutomirski <luto@kernel.org>, ajm@sgi.com,
        Yinghai Lu <yinghai@kernel.org>, Akinobu Mita <akinobu.mita@gmail.com>,
        x86@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] x86/irq: update first_system_vector only when
 X86_LOCAL_PIC is on
In-Reply-To: <CAHz2CGXUYs4aC5WKeekN3bUsr-r_nei6tLLFNSz9h2okmxAdfQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1603131007210.3657@nanos>
References: <cover.1457790776.git.nasa4836@gmail.com> <fa064e4e2fd688a42480f686825f485ade4e30ca.1457790777.git.nasa4836@gmail.com> <alpine.DEB.2.11.1603122104360.3657@nanos> <CAHz2CGXs3cweb9m+m5fS2ZqWkqSbp18eZtOsSAK3KQC+N7f_4A@mail.gmail.com>
 <alpine.DEB.2.11.1603130727460.3657@nanos> <CAHz2CGVZocGSuYa2xq4UeCrGg=CU29XejTfLS0KxFitAttrC4g@mail.gmail.com> <alpine.DEB.2.11.1603130847140.3657@nanos> <CAHz2CGXUYs4aC5WKeekN3bUsr-r_nei6tLLFNSz9h2okmxAdfQ@mail.gmail.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 836
Lines: 25

On Sun, 13 Mar 2016, Jianyu Zhan wrote:
> On Sun, Mar 13, 2016 at 3:55 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > if LOCAL_APIC is disabled it does not use the interrupt, simply because there
> > is no way to trigger it. That setup is inside #ifdef CONFIG_X86_LOCAL_APIC for
> > exactly that reason.
> >
> > Just because IRQ_WORK has no config dependency on LOCAL APIC that does not
> > mean it uses the interrupt gate unconditionally.
> >
> 
> Thanks for clarification.
> 
> I think IRQ_WORK works as generic hardirq context callbacks, it should reply on
> self IPI,  which is a functionality provided by LOCAL_APIC, while
> legacy PIC doesn't
> provide this(correct?).

As I said before IRQ_WORK can work w/o APIC. And therefor IRQ_WORK does NOT
depend on APIC.
 
End of story. Nothing to change here at all.

Thanks,

	tglx