MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.11.1603131032030.3657@nanos>
References: <cover.1457790776.git.nasa4836@gmail.com> <fa064e4e2fd688a42480f686825f485ade4e30ca.1457790777.git.nasa4836@gmail.com>
 <alpine.DEB.2.11.1603122104360.3657@nanos> <CAHz2CGXs3cweb9m+m5fS2ZqWkqSbp18eZtOsSAK3KQC+N7f_4A@mail.gmail.com>
 <alpine.DEB.2.11.1603130727460.3657@nanos> <CAHz2CGVZocGSuYa2xq4UeCrGg=CU29XejTfLS0KxFitAttrC4g@mail.gmail.com>
 <alpine.DEB.2.11.1603130847140.3657@nanos> <CAHz2CGXUYs4aC5WKeekN3bUsr-r_nei6tLLFNSz9h2okmxAdfQ@mail.gmail.com>
 <alpine.DEB.2.11.1603131007210.3657@nanos> <CAHz2CGWDYHoAWQVNxJm+AZkPWN23mOQeR_GQMoybsFoYO9qssg@mail.gmail.com>
 <alpine.DEB.2.11.1603131032030.3657@nanos>
From: Jianyu Zhan <nasa4836@gmail.com>
Date: Sun, 13 Mar 2016 18:08:54 +0800
Message-ID: <CAHz2CGXuNtgq1wmwrqaj+A751DQ1knycEDwnWSwgnB2oq38zJA@mail.gmail.com>
Subject: Re: [PATCH 3/3] x86/irq: update first_system_vector only when
 X86_LOCAL_PIC is on
To: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo@redhat.com, "H. Peter Anvin" <hpa@zytor.com>,
        Aravind.Gopalakrishnan@amd.com, brgerst@gmail.com, bp@suse.de,
        feng.wu@intel.com, jiang.liu@linux.intel.com,
        Tejun Heo <tj@kernel.org>, dvlasenk@redhat.com, penberg@cs.helsinki.fi,
        Yinghai Lu <yhlu.kernel@gmail.com>, andi@firstfloor.org,
        Andy Lutomirski <luto@kernel.org>, ajm@sgi.com,
        Yinghai Lu <yinghai@kernel.org>, Akinobu Mita <akinobu.mita@gmail.com>,
        x86@kernel.org, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 933
Lines: 32

On Sun, Mar 13, 2016 at 5:33 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
>       IRQ_WORK can work w/o APIC
>
> Emphasis on CAN. If the APIC is available it's used, if not then there is no
> point in setting up the gate for nothing.
>
> So why would your patch do any good?

I understood it is no point setting up if  APIC is not available,  but
just got confused by
your wording 'can',  now all clear.

As for the patch set.   My initial purpose is just wanting to make the
layout clear and
clean up stale comments and dead code:

#ifndef CONFIG_X86_LOCAL_APIC
#define first_system_vector NR_VECTORS
#endif

as we've talked about this before,  it won't ever be change on
!CONFIG_X86_LOCAL_APIC,
so no point define it here(it is initialized to NR_VECTORS).

Since all points are clear now, if  the above purpose still make sense.
I will  respin this patch set.

Thank you for your patient explanation .:-)


Regards,
Jianyu Zhan