Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932484AbcCMKO7 (ORCPT ); Sun, 13 Mar 2016 06:14:59 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:38752 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752699AbcCMKOu (ORCPT ); Sun, 13 Mar 2016 06:14:50 -0400 Subject: Re: [RFC] tty: n_tty -- Add new TIOCPEEKRAW ioctl to peek unread data To: Cyrill Gorcunov , LKML References: <20160312141830.GM1989@uranus.lan> Cc: Peter Hurley , Greg Kroah-Hartman , Andrey Vagin , Konstantin Khorenko , Vladimir Davydov , Pavel Emelianov From: Jiri Slaby Message-ID: <56E53D96.3010107@suse.cz> Date: Sun, 13 Mar 2016 11:14:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160312141830.GM1989@uranus.lan> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 602 Lines: 16 On 03/12/2016, 03:18 PM, Cyrill Gorcunov wrote: > --- linux-ml.git.orig/include/uapi/asm-generic/ioctls.h > +++ linux-ml.git/include/uapi/asm-generic/ioctls.h > @@ -77,6 +77,7 @@ > #define TIOCGPKT _IOR('T', 0x38, int) /* Get packet mode state */ > #define TIOCGPTLCK _IOR('T', 0x39, int) /* Get Pty lock state */ > #define TIOCGEXCL _IOR('T', 0x40, int) /* Get exclusive mode state */ > +#define TIOCPEEKRAW _IOR('T', 0x41, void *) Hi, this is not 32/64bit compatible and would need a compat ioctl number and a wrapper. Since it is char *, could you make it just 'char'? thanks, -- js suse labs