Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932911AbcCMNjM (ORCPT <rfc822;w@1wt.eu>);
	Sun, 13 Mar 2016 09:39:12 -0400
Received: from mail.savoirfairelinux.com ([208.88.110.44]:39731 "EHLO
	mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932483AbcCMNjH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 13 Mar 2016 09:39:07 -0400
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Ido Schimmel <idosch@mellanox.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel@savoirfairelinux.com, "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Jiri Pirko <jiri@resnulli.us>,
        Kevin Smith <kevin.smith@elecsyscorp.com>
Subject: Re: [RFC PATCH net-next 3/3] net: dsa: refine netdev event notifier
In-Reply-To: <20160313073250.GA2955@colbert.mtl.com>
References: <1457851346-26257-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1457851346-26257-4-git-send-email-vivien.didelot@savoirfairelinux.com> <20160313073250.GA2955@colbert.mtl.com>
User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu)
Date: Sun, 13 Mar 2016 09:39:02 -0400
Message-ID: <878u1mlcp5.fsf@ketchup.mtl.sfl>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 430
Lines: 17

Hi Ido,

Ido Schimmel <idosch@mellanox.com> writes:

>>+	case NETDEV_PRECHANGEUPPER:
>
> Why do you need this here? It seems you are always ignoring it in
> dsa_slave_port_upper_event()? Probably better to introduce it when you
> actually need it.
>
> Other than that, it looks good to me.

I've prepare a real v1 without this switch case locally, I'll send it in
a few moment unless there are other comments.

Thanks Ido!
Vivien