Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754042AbcCMOax (ORCPT ); Sun, 13 Mar 2016 10:30:53 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:36361 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbcCMOap (ORCPT ); Sun, 13 Mar 2016 10:30:45 -0400 Subject: Re: [PATCH v2 2/9] net: arc_emac: add phy reset is optional for device tree To: Caesar Wang , Heiko Stuebner , "David S. Miller" , Rob Herring References: <1457860062-5514-1-git-send-email-wxt@rock-chips.com> <1457860062-5514-3-git-send-email-wxt@rock-chips.com> Cc: linux-rockchip@lists.infradead.org, keescook@google.com, leozwang@google.com, netdev@vger.kernel.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <56E57976.4080507@cogentembedded.com> Date: Sun, 13 Mar 2016 17:30:14 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457860062-5514-3-git-send-email-wxt@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1383 Lines: 43 Hello. On 3/13/2016 12:07 PM, Caesar Wang wrote: > This patch adds the following property for arc_emac. > > 1) reset-gpios: > The phy reset-gpio is an optional property for arc emac device tree boot. > Change the binding document to match the driver code. > > 2) phy-reset-duration: > Different boards may require different phy reset duration. Add property > phy-reset-duration for device tree probe, so that the boards that need > a longer reset duration can specify it in their device tree. > > Anyway, we can add the above property for arc emac. > > Signed-off-by: Caesar Wang > --- > > Changes in v2: None Not true -- you renamed the reset prop. > Documentation/devicetree/bindings/net/arc_emac.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/arc_emac.txt b/Documentation/devicetree/bindings/net/arc_emac.txt > index a1d71eb..8e84b52 100644 > --- a/Documentation/devicetree/bindings/net/arc_emac.txt > +++ b/Documentation/devicetree/bindings/net/arc_emac.txt > @@ -7,6 +7,13 @@ Required properties: > - max-speed: see ethernet.txt file in the same directory. > - phy: see ethernet.txt file in the same directory. > > +Optional properties: > +- reset-gpios : Should specify the gpio for phy reset Please leave the old name, "phy-reset-gpios" was surely better. [...] MBR, Sergei