Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754016AbcCMPAY (ORCPT ); Sun, 13 Mar 2016 11:00:24 -0400 Received: from mail-qk0-f176.google.com ([209.85.220.176]:34530 "EHLO mail-qk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbcCMPAP (ORCPT ); Sun, 13 Mar 2016 11:00:15 -0400 Date: Sun, 13 Mar 2016 11:00:12 -0400 From: Tejun Heo To: Mike Galbraith Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org, a.p.zijlstra@chello.nl, mingo@redhat.com, lizefan@huawei.com, hannes@cmpxchg.org, pjt@google.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-api@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCHSET RFC cgroup/for-4.6] cgroup, sched: implement resource group and PRIO_RGRP Message-ID: <20160313150012.GB13405@htj.duckdns.org> References: <1457710888-31182-1-git-send-email-tj@kernel.org> <1457764019.10402.72.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457764019.10402.72.camel@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2175 Lines: 47 Hello, Mike. On Sat, Mar 12, 2016 at 07:26:59AM +0100, Mike Galbraith wrote: > Hrm. You're showing that per-thread groups can coexist just fine, > which is good given need and usage exists today out in the wild. Why > do such groups have to be invisible with a unique interface though? I tried to explain these in the forementioned RFD document. I'll give a brief example here. Let's say there is an application which wants to manage resource distributions across its multiple threadpools in a hierarchical way. With cgroupfs interface as the only system-wide interface, it has to coordinate who or whatever is managing that interface. Maybe it can get a subtree delegated to it, maybe it has to ask the system thing to create and place threads there, maybe it can just expose the pids and let the system management do its thing (what if the threads in the pools are dynamic tho?). There is no reliable universal way of doing this. Each such application has to be ready to specifically coordinate with the specific system management in use. This is kernel failing to provide proper abstraction and isolation between different layers. The "raw" feature is there but it's unsafe to use and thus can't be used widely. > Given the core has to deal with them whether they're visible or not, > and given they exist to fulfill a need, seems they should be first > class citizens, not some Quasimodo like creature sneaking into the > cathedral via a back door and slinking about in the shadows. In terms of programmability and accessibility for individual applications, group resource management being available through straight-forward and incremental extension of exsiting mechanisms is *way* more first class citizen. It is two seamless extensions to clone(2) and setpriority(2) making hierarchical resource management generally available to applications. There can be use cases where building cpu resource hierarchy which is completely alien to how the rest of the system is organized is useful. For those cases, the only thing which can be done is building a separate hierarchy for the cpu controller and that capability isn't going anywhere. Thanks. -- tejun