Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932867AbcCMU5D (ORCPT ); Sun, 13 Mar 2016 16:57:03 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34758 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932504AbcCMU44 (ORCPT ); Sun, 13 Mar 2016 16:56:56 -0400 Date: Sun, 13 Mar 2016 21:56:54 +0100 From: Jiri Pirko To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli , Andrew Lunn , Ido Schimmel , Kevin Smith Subject: Re: [PATCH net-next 2/3] net: dsa: make port_bridge_leave return void Message-ID: <20160313205653.GC2274@nanopsycho.orion> References: <1457900494-10266-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1457900494-10266-3-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1457900494-10266-3-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 467 Lines: 10 Sun, Mar 13, 2016 at 09:21:33PM CET, vivien.didelot@savoirfairelinux.com wrote: >netdev_upper_dev_unlink() which notifies NETDEV_CHANGEUPPER, returns >void, as well as del_nbp(). So there's no advantage to catch an eventual >error from the port_bridge_leave routine at the DSA level. > >Make this routine void for the DSA layer and its existing drivers. > >Signed-off-by: Vivien Didelot Acked-by: Jiri Pirko