Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932960AbcCMVge (ORCPT ); Sun, 13 Mar 2016 17:36:34 -0400 Received: from mail-qg0-f47.google.com ([209.85.192.47]:34174 "EHLO mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752063AbcCMVg3 (ORCPT ); Sun, 13 Mar 2016 17:36:29 -0400 MIME-Version: 1.0 From: Denys Vlasenko Date: Sun, 13 Mar 2016 22:36:08 +0100 Message-ID: Subject: Re: [PATCH] direct-io: Deinline dio_zero_block, save 2684 bytes To: Denys Vlasenko Cc: Al Viro , Jens Axboe , Christoph Hellwig , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 20 On Sun, Mar 13, 2016 at 10:00 PM, Denys Vlasenko wrote: > This function compiles to 2684 bytes, 2 callsites > > text data bss dec hex filename > 9655 16 0 9671 25c7 direct-io.o.before2 > 9559 16 0 9575 2567 direct-io.o Al, you undoubtedly noticed the discrepancy between "save 2684 bytes" claim in the commit description and the above data, which shows no such thing. Sorry, I was too quick to send the mail to notice it :( Further investigation had shown that it's my particular version of gcc deciding to deinline the function even before the patch. Other version of gcc, on a different machine was running large inlining search script, did not do that, and saw the 2684 bytes of savings. tl;dr: the patch is correct, my "size" printout wasn't.