Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932727AbcCMXC0 (ORCPT ); Sun, 13 Mar 2016 19:02:26 -0400 Received: from mail-vk0-f50.google.com ([209.85.213.50]:33774 "EHLO mail-vk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754291AbcCMXCO (ORCPT ); Sun, 13 Mar 2016 19:02:14 -0400 MIME-Version: 1.0 In-Reply-To: <20160311230254.GG2792@jra3> References: <1456733847-17982-1-git-send-email-agruenba@redhat.com> <20160311140134.GA14808@infradead.org> <20160311230254.GG2792@jra3> Date: Mon, 14 Mar 2016 00:02:13 +0100 Message-ID: Subject: Re: [PATCH v18 00/22] Richacls (Core and Ext4) From: Andreas Gruenbacher To: Jeremy Allison Cc: Steve French , Christoph Hellwig , Alexander Viro , "J. Bruce Fields" , Linux NFS Mailing List , "Theodore Ts'o" , "linux-cifs@vger.kernel.org" , Linux API , Trond Myklebust , LKML , XFS Developers , Andreas Dilger , linux-fsdevel , Jeff Layton , linux-ext4 , Anna Schumaker Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 34 On Sat, Mar 12, 2016 at 12:02 AM, Jeremy Allison wrote: > On Fri, Mar 11, 2016 at 02:05:16PM -0600, Steve French wrote: >> Sounds like I need to quickly rework the SMB3 ACL helper functions >> for cifs.ko >> >> Also do you know where is the current version of the corresponding >> vfs_richacl for >> Samba which works with the current RichACL format? > > I have a patch for a new vfs_richacl somewhere. I remember > sending it to Andreas for testing... Ah, the patch was for testing, not resting ... how could I get that mixed up. I've applied your patch to the latest master branch, made it compile again, and fixed a few obvious problems. The results I get with smbcacls look reasonable now. The code is here: https://github.com/andreas-gruenbacher/samba richacl I've used the following smb.conf: [richacl] comment = Richacl directory path = /mnt/ext4 vfs objects = richacl writeable = yes browseable = yes Is there a particular reason why you didn't make vfs_richacl a dynamically loadable module? Thanks, Andreas