Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933073AbcCNA0s (ORCPT ); Sun, 13 Mar 2016 20:26:48 -0400 Received: from gloria.sntech.de ([95.129.55.99]:33345 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932298AbcCNA0k convert rfc822-to-8bit (ORCPT ); Sun, 13 Mar 2016 20:26:40 -0400 From: Heiko Stuebner To: Shawn Lin Cc: Xing Zheng , Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] clk: rockchip: remove redundant checking of device_node Date: Mon, 14 Mar 2016 01:26:33 +0100 Message-ID: <2962531.qNIN5DvN6o@phil> User-Agent: KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1457799953-3267-1-git-send-email-shawn.lin@rock-chips.com> References: <1457799871-3015-1-git-send-email-shawn.lin@rock-chips.com> <1457799953-3267-1-git-send-email-shawn.lin@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 377 Lines: 12 Am Sonntag, 13. M?rz 2016, 00:25:53 schrieb Shawn Lin: > rockchip_clk_of_add_provider is used by sub-clk driver which > already call of_iomap before calling it. If device_node does > not exist, of_iomap returns NULL which will fail to init the > sub-clk driver. So really it's redundant. > > Signed-off-by: Shawn Lin applied for v4.7 Thanks Heiko