Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933133AbcCNAqX (ORCPT ); Sun, 13 Mar 2016 20:46:23 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:57719 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932854AbcCNAqN (ORCPT ); Sun, 13 Mar 2016 20:46:13 -0400 Subject: Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt To: Sergei Shtylyov , References: <1457053798-93513-1-git-send-email-huangdaode@hisilicon.com> <1457053798-93513-4-git-send-email-huangdaode@hisilicon.com> <56D98F8F.5010700@cogentembedded.com> <56E2251D.905@hisilicon.com> <56E2C839.4000700@cogentembedded.com> CC: , , , , , , , , , , From: Daode Huang Message-ID: <56E60999.90703@hisilicon.com> Date: Mon, 14 Mar 2016 08:45:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56E2C839.4000700@cogentembedded.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.61.13.197] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.56E609A7.009D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 41f1fa659b9bb4a452b805747f51b1f9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 55 On 2016/3/11 21:29, Sergei Shtylyov wrote: > Hello. > > On 3/11/2016 4:53 AM, Daode Huang wrote: > >>>> In V2 chip, when sending mamagement packets, the driver should >>>> config the port id to BD descs. >>>> >>>> Signed-off-by: Daode Huang >>>> Signed-off-by: Lisheng >>>> --- >>>> drivers/net/ethernet/hisilicon/hns/hnae.h | 3 +++ >>>> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 + >>>> drivers/net/ethernet/hisilicon/hns/hns_enet.c | 4 ++++ >>>> 3 files changed, 8 insertions(+) >>>> >>>> diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h >>>> b/drivers/net/ethernet/hisilicon/hns/hnae.h >>>> index 1cbcb9f..11a3f97 100644 >>>> --- a/drivers/net/ethernet/hisilicon/hns/hnae.h >>>> +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h >>> [...] >>>> @@ -516,6 +518,7 @@ struct hnae_handle { >>>> int q_num; >>>> int vf_id; >>>> u32 eport_id; >>>> + u32 dport_id; /*v2 tx bd should fill the dport_id*/ >>> >>> Please add spaces after /* and before */ (like it's done in other >>> places >>> in this driver). >>> >> >> Hi MBR, Sergei, > > Just in case: MBR stands for "my best regards", Sergei is my name. :-) hi Sergei, So sorry for my misunderstanding. thanks for your reminding. Best Regards Daode. > >> Daode. > > MBR, Sergei > > > . >