Message-ID: <1457917752.10465.6.camel@talk21.com>
Subject: Re: [PATCH] x86/efi: Always map boot service regions into new EFI
 page tables
From: Scott Ashcroft <scott.ashcroft@talk21.com>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Ingo Molnar <mingo@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Matthew Garrett <mjg59@srcf.ucam.org>, Borislav Petkov <bp@alien8.de>,
        Ben Hutchings <ben@decadent.org.uk>,
        Raphael Hertzog <hertzog@debian.org>,
        Roger Shimizu <rogershimizu@gmail.com>,
        Alexis Murzeau <amurzeau@gmail.com>
Date: Mon, 14 Mar 2016 01:09:12 +0000
In-Reply-To: <20160313230736.GB2619@codeblueprint.co.uk>
References: <1457695163-29632-1-git-send-email-matt@codeblueprint.co.uk>
	 <1457695163-29632-2-git-send-email-matt@codeblueprint.co.uk>
	 <1457888975.3884.9.camel@talk21.com>
	 <20160313215847.GA2619@codeblueprint.co.uk>
	 <20160313230736.GB2619@codeblueprint.co.uk>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 751
Lines: 25

On Sun, 2016-03-13 at 23:07 +0000, Matt Fleming wrote:
> Assuming the answer to this question is "no", can you try out this
> patch?
> 
> diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
> index 8fee5b6f8f66..af74849e8c0f 100644
> --- a/arch/x86/mm/pageattr.c
> +++ b/arch/x86/mm/pageattr.c
> @@ -1055,7 +1055,7 @@ static int populate_pud(struct cpa_data *cpa,
> unsigned long start, pgd_t *pgd,
>  	/*
>  	 * Map everything starting from the Gb boundary, possibly
> with 1G pages
>  	 */
> -	while (end - start >= PUD_SIZE) {
> +	while (cpu_has_gbpages && end - start >= PUD_SIZE) {
>  		set_pud(pud, __pud(cpa->pfn << PAGE_SHIFT |
> _PAGE_PSE |
>  				   massage_pgprot(pud_pgprot)));
> 

Yes, that does fix it.

Cheers,
Scott