Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754574AbcCNCkU (ORCPT <rfc822;w@1wt.eu>);
	Sun, 13 Mar 2016 22:40:20 -0400
Received: from regular1.263xmail.com ([211.150.99.135]:42447 "EHLO
	regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754254AbcCNCkQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 13 Mar 2016 22:40:16 -0400
X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S;
X-MAIL-GRAY: 0
X-MAIL-DELIVERY: 1
X-KSVirus-check: 0
X-ABS-CHECKED: 1
X-SKE-CHECKED: 1
X-ADDR-CHECKED: 0
X-RL-SENDER: mark.yao@rock-chips.com
X-FST-TO: linux-kernel@vger.kernel.org
X-SENDER-IP: 58.22.7.114
X-LOGIN-NAME: mark.yao@rock-chips.com
X-UNIQUE-TAG: <c34ba31b9a459acaa61749c0ae76c918>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Message-ID: <56E62486.7050700@rock-chips.com>
Date: Mon, 14 Mar 2016 10:40:06 +0800
From: Mark yao <mark.yao@rock-chips.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: John Keeping <john@metanate.com>
CC: David Airlie <airlied@linux.ie>, Heiko Stuebner <heiko@sntech.de>,
        dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/rockchip: cancel pending vblanks on close
References: <1457716877-427-1-git-send-email-john@metanate.com>
In-Reply-To: <1457716877-427-1-git-send-email-john@metanate.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1125
Lines: 31

On 2016年03月12日 01:21, John Keeping wrote:
> When closing the DRM device while a vblank is pending, we access
> file_priv after it has been free'd, which gives:
>
>    Unable to handle kernel NULL pointer dereference at virtual address 00000000
>    ...
>    PC is at __list_add+0x5c/0xe8
>    LR is at send_vblank_event+0x54/0x1f0
>    ...
>    [<c02952e8>] (__list_add) from [<c031a7b4>] (send_vblank_event+0x54/0x1f0)
>    [<c031a760>] (send_vblank_event) from [<c031a9c0>] (drm_send_vblank_event+0x70/0x78)
>    [<c031a950>] (drm_send_vblank_event) from [<c031a9f8>] (drm_crtc_send_vblank_event+0x30/0x34)
>    [<c031a9c8>] (drm_crtc_send_vblank_event) from [<c0339ad8>] (vop_isr+0x224/0x28c)
>    [<c03398b4>] (vop_isr) from [<c0081780>] (handle_irq_event_percpu+0x12c/0x3e4)
>
> This can be triggered somewhat reliably with:
>
> 	modetest -M rockchip -v -s ...
>
> Add a preclose hook to the driver so that we can discard any pending
> vblank events when the device is closed.
>
> Signed-off-by: John Keeping <john@metanate.com>

Looks good for me, applied into my drm-fixes.

Thanks for the fix.

-- 
Ｍark Yao