Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933556AbcCNDQY (ORCPT ); Sun, 13 Mar 2016 23:16:24 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:34093 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932411AbcCNDQM (ORCPT ); Sun, 13 Mar 2016 23:16:12 -0400 MIME-Version: 1.0 In-Reply-To: <56DED13E.9060106@intel.com> References: <1457316477-8153-1-git-send-email-acourbot@nvidia.com> <1457316477-8153-4-git-send-email-acourbot@nvidia.com> <56DED13E.9060106@intel.com> From: Alexandre Courbot Date: Mon, 14 Mar 2016 12:15:51 +0900 Message-ID: Subject: Re: [PATCH v4 3/3] mmc: sdhci-pci: Do not set DMA mask in enable_dma() To: Adrian Hunter Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Alexandre Courbot , Ulf Hansson , Arnd Bergmann , linux-mmc , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 21 On Tue, Mar 8, 2016 at 10:18 PM, Adrian Hunter wrote: > On 07/03/16 04:07, Alexandre Courbot wrote: >> DMA mask will already be set by sdhci_set_dma_mask(), which >> is equivalent to the removed code since pci_set_dma_mask() >> expands to its DMA-API counterpart. >> >> There should also be no reason to set the DMA mask after probe. > > Let's run that by the PCI mailing list just to be sure. The patches for > reference: > > http://marc.info/?l=linux-mmc&m=145731654328126&w=2 > http://marc.info/?l=linux-mmc&m=145731654328128&w=2 > > change the sdhci-pci driver to set the DMA mask once during probe instead of > every time during resume. Is there any reason a PCI device driver might > need to set the DMA mask every time during resume? Not seeing much reaction for this patchset. PCI being the only possible point of contention, can we maybe roll it into -next and see what happens?