Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754722AbcCNGcg (ORCPT ); Mon, 14 Mar 2016 02:32:36 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:62357 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754689AbcCNGc1 convert rfc822-to-8bit (ORCPT ); Mon, 14 Mar 2016 02:32:27 -0400 From: Amitkumar Karwar To: "linux-bluetooth@vger.kernel.org" CC: Cathy Luo , "linux-kernel@vger.kernel.org" , Nishant Sarmukadam , Ganapathi Bhat Subject: RE: [PATCH v4] Bluetooth: hci_uart: Support firmware download for Marvell Thread-Topic: [PATCH v4] Bluetooth: hci_uart: Support firmware download for Marvell Thread-Index: AQHRdUR9eOEgav710UakooKWQwShhJ9Yi7DQ Date: Mon, 14 Mar 2016 06:32:24 +0000 Message-ID: <169b736d643e43598eceaad3adbdfe6d@SC-EXCH04.marvell.com> References: <1457006200-8132-1-git-send-email-akarwar@marvell.com> <1457006200-8132-2-git-send-email-akarwar@marvell.com> In-Reply-To: <1457006200-8132-2-git-send-email-akarwar@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.93.176.43] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-03-14_03:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1603140094 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1294 Lines: 35 Hi Marcel, Do you have any comments for this patch? Please let us know if you have any more suggestions for the improvements. > From: Amitkumar Karwar [mailto:akarwar@marvell.com] > Sent: Thursday, March 03, 2016 5:27 PM > To: linux-bluetooth@vger.kernel.org > Cc: Cathy Luo; linux-kernel@vger.kernel.org; Nishant Sarmukadam; > Ganapathi Bhat; Amitkumar Karwar > Subject: [PATCH v4] Bluetooth: hci_uart: Support firmware download for > Marvell > > From: Ganapathi Bhat > > This patch implement firmware download feature for Marvell Bluetooth > devices. If firmware is already downloaded, it will skip downloading. > > Signed-off-by: Ganapathi Bhat > Signed-off-by: Amitkumar Karwar > --- > v2: Fixed compilation warning reported by kbuild test robot > v3: Addressed review comments from Marcel Holtmann > a) Removed vendor specific code from hci_ldisc.c > b) Get rid of static forward declaration > c) Removed unnecessary heavy nesting > d) Git rid of module parameter and global variables > e) Add logic to pick right firmware image > v4: Addresses review comments from Alan > a) Use existing kernel helper APIs instead of writing own. > b) Replace mdelay() with msleep() > --- Regards, Amitkumar