Date: Mon, 14 Mar 2016 08:49:50 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: MaJun <majun258@huawei.com>
cc: Catalin.Marinas@arm.com, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, Will.Deacon@arm.com,
        mark.rutland@arm.com, marc.zyngier@arm.com, jason@lakedaemon.net,
        lizefan@huawei.com, huxinwei@huawei.com, dingtianhong@huawei.com,
        liguozhu@hisilicon.com, guohanjun@huawei.com, zhaojunhua@hisilicon.com
Subject: Re: [PATCH v2 1/2] Irq/mbigen:Change the mbigen node definition in
 dt binding file
In-Reply-To: <1457937907-14008-2-git-send-email-majun258@huawei.com>
Message-ID: <alpine.DEB.2.11.1603140844490.3657@nanos>
References: <1457937907-14008-1-git-send-email-majun258@huawei.com> <1457937907-14008-2-git-send-email-majun258@huawei.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 696
Lines: 28

Majun,

On Mon, 14 Mar 2016, MaJun wrote:

First of all the prefix for irq chip drivers is not "Irq/".

Hint: git log drivers/irqchip 

> From: Ma Jun <majun258@huawei.com>
> 
> For mbigen module, there is a special case that more than one mbigen
> device nodes use the same reg definition in DTS when these devices
> exist in the same mbigen hardware module.

There is a special case, so what?
 
> To fix the mbigen IO remap problem, the mbigen node definition and

Which problem?

> structure are changed based on Mark Rutland's suggestion.

That's really uselss. Nobody has any idea what Mark suggested and in which way
it fixes that unspecified problem you are talking about.

Thanks,

	tglx