Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933871AbcCNJoN (ORCPT ); Mon, 14 Mar 2016 05:44:13 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:17287 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933711AbcCNJoD convert rfc822-to-8bit (ORCPT ); Mon, 14 Mar 2016 05:44:03 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 14 Mar 2016 02:42:35 -0700 Message-ID: <56E687E7.4090802@nvidia.com> Date: Mon, 14 Mar 2016 17:44:07 +0800 From: Wei Ni User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: CC: Eduardo Valentin , , Subject: Re: [PATCH v2] thermal: consistently use int for trip temp References: <1456997626-28298-1-git-send-email-wni@nvidia.com> <56DD3A84.4080304@nvidia.com> <56DE45F7.6060307@nvidia.com> <20160308210900.GB8145@localhost.localdomain> In-Reply-To: <20160308210900.GB8145@localhost.localdomain> X-Originating-IP: [10.19.224.146] X-ClientProxiedBy: HKMAIL104.nvidia.com (10.18.16.13) To HKMAIL101.nvidia.com (10.18.16.10) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 38 On 2016年03月09日 05:09, Eduardo Valentin wrote: > On Tue, Mar 08, 2016 at 11:24:39AM +0800, Wei Ni wrote: >> >> >> On 2016年03月07日 16:23, Wei Ni wrote: >>> There had a build error in previous patch. >>> Fixed it in this version. >>> Please review it. >> >> Add CC: linux-pm@vger.kernel.org >> Hi Rui, Will you take this patch? >>> >>> Thanks. >>> Wei. >>> >>> On 2016年03月03日 17:33, Wei Ni wrote: >>>> The commit 17e8351a7739 consistently use int for temperature, >>>> however it missed a few in trip temperature and thermal_core. >>>> >>>> In current codes, the trip->temperature used "unsigned long" >>>> and zone->temperature used"int", if the temperature is negative >>>> value, it will get wrong result when compare temperature with >>>> trip temperature. >>>> >>>> This patch can fix it. >>>> >>>> Signed-off-by: Wei Ni > > Rui are you collecting this one? > > Acked-by: Eduardo Valentin >