Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933808AbcCNKOa (ORCPT ); Mon, 14 Mar 2016 06:14:30 -0400 Received: from lists.s-osg.org ([54.187.51.154]:53583 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbcCNKOW (ORCPT ); Mon, 14 Mar 2016 06:14:22 -0400 Date: Mon, 14 Mar 2016 07:13:58 -0300 From: Mauro Carvalho Chehab To: Sakari Ailus Cc: Shuah Khan , kyungmin.park@samsung.com, a.hajda@samsung.com, s.nawrocki@samsung.com, kgene@kernel.org, k.kozlowski@samsung.com, laurent.pinchart@ideasonboard.com, hyun.kwon@xilinx.com, soren.brinkmann@xilinx.com, gregkh@linuxfoundation.org, perex@perex.cz, tiwai@suse.com, hans.verkuil@cisco.com, lixiubo@cmss.chinamobile.com, javier@osg.samsung.com, g.liakhovetski@gmx.de, chehabrafael@gmail.com, crope@iki.fi, tommi.franttila@intel.com, dan.carpenter@oracle.com, prabhakar.csengg@gmail.com, hamohammed.sa@gmail.com, der.herr@hofr.at, navyasri.tech@gmail.com, Julia.Lawall@lip6.fr, amitoj1606@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devel@driverdev.osuosl.org, alsa-devel@alsa-project.org Subject: Re: [PATCH] media: add GFP flag to media_*() that could get called in atomic context Message-ID: <20160314071358.27c87dab@recife.lan> In-Reply-To: <20160314072236.GO11084@valkosipuli.retiisi.org.uk> References: <1457833689-4926-1-git-send-email-shuahkh@osg.samsung.com> <20160314072236.GO11084@valkosipuli.retiisi.org.uk> Organization: Samsung X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 31 Em Mon, 14 Mar 2016 09:22:37 +0200 Sakari Ailus escreveu: > Hi Shuah, > > On Sat, Mar 12, 2016 at 06:48:09PM -0700, Shuah Khan wrote: > > Add GFP flags to media_create_pad_link(), media_create_intf_link(), > > media_devnode_create(), and media_add_link() that could get called > > in atomic context to allow callers to pass in the right flags for > > memory allocation. > > > > tree-wide driver changes for media_*() GFP flags change: > > Change drivers to add gfpflags to interffaces, media_create_pad_link(), > > media_create_intf_link() and media_devnode_create(). > > > > Signed-off-by: Shuah Khan > > Suggested-by: Mauro Carvalho Chehab > > What's the use case for calling the above functions in an atomic context? > ALSA code seems to do a lot of stuff at atomic context. That's what happens on my test machine when au0828 gets probed before snd-usb-audio: http://pastebin.com/LEX5LD5K It seems that ALSA USB probe routine (usb_audio_probe) happens in atomic context. Regards, Mauro