Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755511AbcCNKwW (ORCPT ); Mon, 14 Mar 2016 06:52:22 -0400 Received: from down.free-electrons.com ([37.187.137.238]:50513 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754766AbcCNKwL (ORCPT ); Mon, 14 Mar 2016 06:52:11 -0400 Date: Mon, 14 Mar 2016 11:52:08 +0100 From: Maxime Ripard To: Vishnu Patekar Cc: Linus Walleij , Rob Herring , Jon Corbet , =?utf-8?B?UGF3ZcWC?= Moll , Mark Rutland , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Russell King - ARM Linux , Emilio Lopez , Jens Kuske , Hans de Goede , Chen-Yu Tsai , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-sunxi , "linux-gpio@vger.kernel.org" , Michael Turquette , Stephen Boyd , Reinder de Haan , linux-clk Subject: Re: [PATCH v3 01/13] pinctrl: sunxi: Add A83T R_PIO controller support Message-ID: <20160314105208.GM8418@lukather> References: <1457192586-25596-1-git-send-email-vishnupatekar0510@gmail.com> <1457192586-25596-2-git-send-email-vishnupatekar0510@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BDCv8JNaL8ltm7rS" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2525 Lines: 81 --BDCv8JNaL8ltm7rS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, Mar 12, 2016 at 12:48:02PM +0800, Vishnu Patekar wrote: > Hello Linus, >=20 >=20 > On Wed, Mar 9, 2016 at 10:55 AM, Linus Walleij = wrote: > > On Sat, Mar 5, 2016 at 10:42 PM, Vishnu Patekar > > wrote: > > > >> The A83T has R_PIO pin controller, it's same as A23, execpt A83T > >> interrupt bit is 6th and A83T has one extra pin PL12. > >> > >> Signed-off-by: Vishnu Patekar > >> Acked-by: Chen-Yu Tsai > >> Acked-by: Rob Herring > > > > As partly noted by others: > > > >> +config PINCTRL_SUN8I_A83T_R > >> + def_bool MACH_SUN8I > > > > bool > > > >> + depends on RESET_CONTROLLER > > > > Should it rather select RESET_CONTROLLER? > I used depends on and def_bool as it is used for other sunxi pinctrl driv= ers. > Using bool and select will not harm anything. It will, at least in the case of def_bool, since that symbol will not be enabled by default, and you'll have no way to enable it. And RESET_CONTROLLER is a bit messy, since you can't just select it because it also has a dependency on an ARCH_HAS_RESET_CONTROLLER symbol. > Should I change it to bool and select ? or keep it to be uniform with > earlier options? Please keep it that way. Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --BDCv8JNaL8ltm7rS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJW5pfYAAoJEBx+YmzsjxAgqpIP/R5fIuDIUf69/qlopNfwl/kp uftf9w8N7GnTFMEAoydCbQEKMT5GrfqEaXYg4Ie54kq4WvvFEkZdltP+5vt8yi1G UbrENVpQHdQVVwFXbVrooXP2dOvpiGO/DIMfKICT1o0UNtdCTGDhwKeivqOfOLmh khuRW7agJjDW4yCz0dWYEJ9d+M98RYMj2BXtoKq0j4/QvEaO5NPSfwuacQd1Aiuk WulK7a6cgGK7YxWQLd+yegrAyoCqRBNzaaddS7+hUwWKecoJFHqXyeIZCnqdiTwq /n6LtMuZVLuRyLGM1hcKtf+6VuDYybntDvAZgLx8J6lTGOTfs+fQ39xM54stXX5L zb2txtMoD28xVDcftw+HznRa33xiJ/x+hpQwImSeH05Yziw41zTdNiNlpeBTQA8E 68I/l81B5sm0dwBjjAnGv5fla8Uvpc3GSeB3n61zZF3UiJ/yvWm0W67akm4Y6QdL ijYkOxCPzpyb9Q1gA97GpUMehUqg9XmEc2gxmLnoM5/ANtUZGknQWssQwSD8t5Tw NVEo/f22ft2J3jt+fJGxJ7JcfUAZ6P41vKy8gn1vcow5HUdoZvbKkfaxkmkNeKJ+ iK3fcyPHOoRPi3H0SGt+wspq3wg3DwMwsQZvNxBN/t5HU+cGgrXN07K6eUydn8vi oLlHsl+7IM/rWWPsGmtk =jtfl -----END PGP SIGNATURE----- --BDCv8JNaL8ltm7rS--