Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934082AbcCNK6x (ORCPT ); Mon, 14 Mar 2016 06:58:53 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:37536 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932210AbcCNK6o (ORCPT ); Mon, 14 Mar 2016 06:58:44 -0400 Date: Mon, 14 Mar 2016 13:58:13 +0300 From: Dan Carpenter To: Minfei Huang Cc: walter harms , xlpang@redhat.com, Andrew Morton , Vivek Goyal , Dave Young , Ingo Molnar , Toshi Kani , Mimi Zohar , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] kexec: potetially using uninitialized variable Message-ID: <20160314105813.GL5273@mwanda> References: <20160311080747.GA31887@mwanda> <56E2875B.8010909@redhat.com> <20160311091919.GD5273@mwanda> <56E2944E.3030204@bfs.de> <20160311153819.GA14320@mhuang-ThinkPad-T440s> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160311153819.GA14320@mhuang-ThinkPad-T440s> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 422 Lines: 10 On Fri, Mar 11, 2016 at 11:38:19PM +0800, Minfei Huang wrote: > I think we can modify the logic a bit to make code simple. Thus gcc will > not complain about any more, and the logic is earier. This is a Smatch warning, not a GCC warning. If you think the new code is clearer, that's fine but don't just silence the warning to please Smatch. I'm pretty sure I can silence this warning in Smatch. regards, dan carpenter