Date: Mon, 14 Mar 2016 19:25:25 +0800
From: Minfei Huang <mnfhuang@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: walter harms <wharms@bfs.de>, xlpang@redhat.com,
        Andrew Morton <akpm@linux-foundation.org>,
        Vivek Goyal <vgoyal@redhat.com>, Dave Young <dyoung@redhat.com>,
        Ingo Molnar <mingo@kernel.org>, Toshi Kani <toshi.kani@hpe.com>,
        Mimi Zohar <zohar@linux.vnet.ibm.com>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [patch] kexec: potetially using uninitialized variable
Message-ID: <20160314112525.GA3216@mhuang-ThinkPad-T440s>
References: <20160311080747.GA31887@mwanda>
 <56E2875B.8010909@redhat.com>
 <20160311091919.GD5273@mwanda>
 <56E2944E.3030204@bfs.de>
 <20160311153819.GA14320@mhuang-ThinkPad-T440s>
 <20160314105813.GL5273@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160314105813.GL5273@mwanda>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 606
Lines: 20

On 03/14/16 at 01:58pm, Dan Carpenter wrote:
> On Fri, Mar 11, 2016 at 11:38:19PM +0800, Minfei Huang wrote:
> > I think we can modify the logic a bit to make code simple. Thus gcc will
> > not complain about any more, and the logic is earier.
> 
> This is a Smatch warning, not a GCC warning.  If you think the new code
> is clearer, that's fine but don't just silence the warning to please
> Smatch.  I'm pretty sure I can silence this warning in Smatch.
> 
> regards,
> dan carpenter
> 

Hi, Dan.

If not a GCC warning, I'm fine to fix it in Smatch, since the code logic
is clear enough.

Thanks
Minfei