From: Arnd Bergmann <arnd@arndb.de>
To: Hannes Reinecke <hare@suse.de>
Cc: martin.petersen@oracle.com, James.Bottomley@hansenpartnership.com,
        James Smart <james.smart@avagotech.com>,
        Dick Kennedy <dick.kennedy@avagotech.com>,
        "James E.J. Bottomley" <JBottomley@odin.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Hannes Reinecke <hare@suse.com>, Sebastian Herbszt <herbszt@gmx.de>
Subject: Re: [PATCH 2/3] lpfc: fix misleading indentation
Date: Mon, 14 Mar 2016 16:25:09 +0100
Message-ID: <13330994.pIJCLN5xX1@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <56E6D69E.1050008@suse.de>
References: <1457965789-3373916-1-git-send-email-arnd@arndb.de> <1457965789-3373916-3-git-send-email-arnd@arndb.de> <56E6D69E.1050008@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1191
Lines: 38

On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote:
> >       vports = lpfc_create_vport_work_array(phba);
> > -     if (vports != NULL)
> > +     if (vports != NULL) {
> >               for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++) {
> >                       struct Scsi_Host *shost;
> >                       shost = lpfc_shost_from_vport(vports[i]);
> > @@ -2877,7 +2877,8 @@ lpfc_online(struct lpfc_hba *phba)
> >                       }
> >                       spin_unlock_irq(shost->host_lock);
> >               }
> > -             lpfc_destroy_vport_work_array(phba, vports);
> > +     }
> > +     lpfc_destroy_vport_work_array(phba, vports);
> >  
> >       lpfc_unblock_mgmt_io(phba);
> >       return 0;
> > 
> Nope.
> 
> vports is only valid from within the indentation block, so it should
> be moved into it.
> 
> 

Well, every other user of the function also looks like

	vports = lpfc_create_vport_work_array(phba);
	if (vports != NULL) {
		do_something(vports);
	}
	lpfc_destroy_vport_work_array(phba, vports);

and lpfc_destroy_vport_work_array() does nothing if its argument is NULL.

I still think my patch is the correct fix for the warning.

	Arnd