Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbcCNQjb (ORCPT ); Mon, 14 Mar 2016 12:39:31 -0400 Received: from casper.infradead.org ([85.118.1.10]:60771 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbcCNQj1 (ORCPT ); Mon, 14 Mar 2016 12:39:27 -0400 Date: Mon, 14 Mar 2016 17:39:14 +0100 From: Peter Zijlstra To: Borislav Petkov Cc: Suravee Suthikulpanit , joro@8bytes.org, mingo@redhat.com, acme@kernel.org, andihartmann@freenet.de, vw@iommu.org, labbott@redhat.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH V5 02/10] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Message-ID: <20160314163913.GO6344@twins.programming.kicks-ass.net> References: <1456236764-1569-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1456236764-1569-3-git-send-email-Suravee.Suthikulpanit@amd.com> <20160312132224.GI6344@twins.programming.kicks-ass.net> <56E64B68.3090505@amd.com> <20160314095856.GL6344@twins.programming.kicks-ass.net> <56E6BE7E.8010807@amd.com> <20160314141945.GE15800@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160314141945.GE15800@pd.tnic> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 18 On Mon, Mar 14, 2016 at 03:19:45PM +0100, Borislav Petkov wrote: > On Mon, Mar 14, 2016 at 08:37:02PM +0700, Suravee Suthikulpanit wrote: > > Basically, we are trying to match the current Perf hierarchy for AMD IOMMU > > (arch/x86/events/amd/iommu.c). I can put it into > > arch/x86/include/asm/perf_amd_iommu.h. What would you prefer? > > Yeah, I was going to say the same thing - match the hierarchy so that > there are no confusions between paths. Makes sense to me. Well there's still the 'perf' vs' events' thing, but also what other files did you want to put there? For now I think I prefer a filename without extra directories; we can always move files about if there's more use later. Also, since its being used by both events/amd/iommu.c and drivers/iommu/amd_iommu.c you can also chose a name in the latter namespace.