Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753717AbcCNRGp (ORCPT ); Mon, 14 Mar 2016 13:06:45 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47710 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753614AbcCNRGm (ORCPT ); Mon, 14 Mar 2016 13:06:42 -0400 Date: Mon, 14 Mar 2016 13:06:39 -0400 (EDT) Message-Id: <20160314.130639.328854823799037233.davem@davemloft.net> To: arnd@arndb.de Cc: nbd@openwrt.org, blogic@openwrt.org, matthias.bgg@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] net: mediatek: remove incorrect dma_mask assignment From: David Miller In-Reply-To: <1457964435-2945038-2-git-send-email-arnd@arndb.de> References: <1457964435-2945038-1-git-send-email-arnd@arndb.de> <1457964435-2945038-2-git-send-email-arnd@arndb.de> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 14 Mar 2016 10:06:41 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 446 Lines: 15 From: Arnd Bergmann Date: Mon, 14 Mar 2016 15:07:11 +0100 > Device drivers should not mess with the DMA mask directly, > but instead call dma_set_mask() etc if needed. > > In case of the mtk_eth_soc driver, the mask already gets set > correctly when the device is created, and setting it again > is against the documented API. > > This removes the incorrect setting. > > Signed-off-by: Arnd Bergmann Applied.