Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753800AbcCNRGw (ORCPT ); Mon, 14 Mar 2016 13:06:52 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47741 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753618AbcCNRGs (ORCPT ); Mon, 14 Mar 2016 13:06:48 -0400 Date: Mon, 14 Mar 2016 13:06:45 -0400 (EDT) Message-Id: <20160314.130645.572195280477206552.davem@davemloft.net> To: arnd@arndb.de Cc: nbd@openwrt.org, blogic@openwrt.org, matthias.bgg@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] net: mediatek: check device_reset return code From: David Miller In-Reply-To: <1457964435-2945038-3-git-send-email-arnd@arndb.de> References: <1457964435-2945038-1-git-send-email-arnd@arndb.de> <1457964435-2945038-3-git-send-email-arnd@arndb.de> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 14 Mar 2016 10:06:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 685 Lines: 16 From: Arnd Bergmann Date: Mon, 14 Mar 2016 15:07:12 +0100 > The device_reset() function may fail, so we have to check > its return value, e.g. to make deferred probing work correctly. > gcc warns about it because of the warn_unused_result attribute: > > drivers/net/ethernet/mediatek/mtk_eth_soc.c: In function 'mtk_probe': > drivers/net/ethernet/mediatek/mtk_eth_soc.c:1679:2: error: ignoring return value of 'device_reset', declared with attribute warn_unused_result [-Werror=unused-result] > > This adds the trivial error check to propagate the return value > to the generic platform device probe code. > > Signed-off-by: Arnd Bergmann Applied.