Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933483AbcCNSPS (ORCPT ); Mon, 14 Mar 2016 14:15:18 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:36422 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933122AbcCNSPL (ORCPT ); Mon, 14 Mar 2016 14:15:11 -0400 MIME-Version: 1.0 In-Reply-To: References: <20160314120202.GD15800@pd.tnic> Date: Mon, 14 Mar 2016 11:15:09 -0700 X-Google-Sender-Auth: m8t7MUjd5mEwbepncx-NCFyvw3I Message-ID: Subject: Re: [PATCH v4 2/5] x86/msr: Carry on after a non-"safe" MSR access fails without !panic_on_oops From: Linus Torvalds To: Andy Lutomirski Cc: Paolo Bonzini , xen-devel , Arjan van de Ven , Borislav Petkov , X86 ML , Andrew Morton , KVM list , Andy Lutomirski , "linux-kernel@vger.kernel.org" , Peter Zijlstra Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 541 Lines: 15 On Mon, Mar 14, 2016 at 11:10 AM, Andy Lutomirski wrote: > > A couple of the wrmsr users actually care about performance. These > are the ones involved in context switching and, to a lesser extent, in > switching in and out of guest mode. .. ok, see the crossed emails. I'd *much* rather special case the special cases. Not make the generic case something complex. And *particularly* not make the generic case be something where people think it's sane to oops and kill the machine. Christ. Linus