Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933458AbcCNSUc (ORCPT ); Mon, 14 Mar 2016 14:20:32 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35787 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933306AbcCNSU1 (ORCPT ); Mon, 14 Mar 2016 14:20:27 -0400 MIME-Version: 1.0 In-Reply-To: <56E65EFC.3030109@huawei.com> References: <56E65EFC.3030109@huawei.com> Date: Mon, 14 Mar 2016 23:50:25 +0530 Message-ID: Subject: Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code) From: Parav Pandit To: oulijun Cc: "Wei Hu(Xavier)" , Doug Ledford , "Hefty, Sean" , Hal Rosenstock , davem@davemloft.net, jeffrey.t.kirsher@intel.com, jiri@mellanox.com, Or Gerlitz , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, gongyangming@huawei.com, xiaokun@huawei.com, tangchaofei@huawei.com, haifeng.wei@huawei.com, yisen.zhuang@huawei.com, yankejian@huawei.com, lisheng011@huawei.com, charles.chenxin@huawei.com, linuxarm@huawei.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 568 Lines: 14 >> >> Since SRQ is not supported in this driver version, can you keep >> remaining code base also to not bother about SRQ specifically >> poll_cq_one, modify_qp, destroy_qp etc? >> SRQ support can come as complete additional patch along with cmd_mask, >> callbacks and rest of the code. >> >> . > Sorry, I see your review in time. > Sure, SRQ is not supported in current roce driver. I have verified the function > for RDMA. It is not influence. For your question, we need to analyse it scientific. > after that, i will reply your doubt, is that ok? Yes. No problem.