Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932797AbcCNTT2 (ORCPT ); Mon, 14 Mar 2016 15:19:28 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:48944 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932069AbcCNTT0 (ORCPT ); Mon, 14 Mar 2016 15:19:26 -0400 Date: Mon, 14 Mar 2016 15:19:23 -0400 (EDT) Message-Id: <20160314.151923.1878027262976947807.davem@davemloft.net> To: glider@google.com Cc: edumazet@google.com, rweikusat@mobileactivedefense.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] SOCK_SEQPACKET socketpair must get SIGPIPE in AF_UNIX if one end is closed From: David Miller In-Reply-To: <1457532623-125301-1-git-send-email-glider@google.com> References: <1457532623-125301-1-git-send-email-glider@google.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 14 Mar 2016 12:19:26 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 26 From: Alexander Potapenko Date: Wed, 9 Mar 2016 15:10:23 +0100 > According to IEEE Std 1003.1, 2013, sending data to a SOCK_SEQPACKET > socketpair with MSG_NOSIGNAL flag set must result in a SIGPIPE if the > socket is no longer connected. > > Signed-off-by: Alexander Potapenko Please format your Subject line properly, the format is: [PATCH] $SUBSYSTEM: $DESCRIPTION. In this case "af_unx: " would be a proper subsystem marker. Also, > --- > I used the following program to check the kernel behavior: Please include this in your commit message rather than cutting it out using the "---" marker, as it will help people in the future understand your change and how you tested it. More information is always better than less information. Thanks.