Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756012AbcCNTZL (ORCPT ); Mon, 14 Mar 2016 15:25:11 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:48999 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755736AbcCNTZF (ORCPT ); Mon, 14 Mar 2016 15:25:05 -0400 Date: Mon, 14 Mar 2016 15:25:02 -0400 (EDT) Message-Id: <20160314.152502.1823929263984045274.davem@davemloft.net> To: elfring@users.sourceforge.net Cc: b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, a@unstable.cc, mareklindner@neomailbox.ch, sw@simonwunderlich.de, sven@narfation.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, julia.lawall@lip6.fr Subject: Re: [PATCH] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection From: David Miller In-Reply-To: <56E2BCD8.9010200@users.sourceforge.net> References: <564EFC67.7050307@users.sourceforge.net> <1655341.WCvHHx7pqD@bentobox> <56E2BCD8.9010200@users.sourceforge.net> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 14 Mar 2016 12:25:04 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 17 From: SF Markus Elfring Date: Fri, 11 Mar 2016 13:40:56 +0100 > From: Markus Elfring > Date: Fri, 11 Mar 2016 13:10:20 +0100 > > The variables "tt_local_entry" and "tt_global_entry" were eventually > checked again despite of a corresponding null pointer test before. > > * Avoid this double check by reordering a function call sequence > and the better selection of jump targets. > > * Omit the initialisation for these variables at the beginning then. > > Signed-off-by: Markus Elfring I am assuming Antonio will take this in via his tree.