Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933141AbcCNUAl (ORCPT ); Mon, 14 Mar 2016 16:00:41 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:33837 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932551AbcCNUAh (ORCPT ); Mon, 14 Mar 2016 16:00:37 -0400 Date: Mon, 14 Mar 2016 20:00:33 +0000 From: Matt Fleming To: "Chen, Yu C" Cc: "linux-acpi@vger.kernel.org" , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Len Brown , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Zhang, Rui" , "linux-efi@vger.kernel.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Ard Biesheuvel , Mark Salter Subject: Re: [PATCH][RFC,v4] ACPI / PM: Introduce efi poweroff for HW-full platforms without _S5 Message-ID: <20160314200033.GG2619@codeblueprint.co.uk> References: <1457687133-3730-1-git-send-email-yu.c.chen@intel.com> <20160311155546.GJ15775@codeblueprint.co.uk> <36DF59CE26D8EE47B0655C516E9CE640286D442A@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <36DF59CE26D8EE47B0655C516E9CE640286D442A@shsmsx102.ccr.corp.intel.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 536 Lines: 13 On Fri, 11 Mar, at 04:33:46PM, Chen, Yu C wrote: > > There is a future Base-IA platform, we are planning to skip > implementing the SLP_TYP register and the S5 object. (already there > will be no S3 and no S4) Cool. This is really valuable information that should go into the commit message. Because if this is the rationale for the change, I don't see why we'd need to provide the default stuff. Instead we should just enforce EFI reboot, and only add the pm_poweroff_default hook if there is an explicit user in the future, IMO.