Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756088AbcCNU31 (ORCPT ); Mon, 14 Mar 2016 16:29:27 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49285 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753263AbcCNU3Y (ORCPT ); Mon, 14 Mar 2016 16:29:24 -0400 Date: Mon, 14 Mar 2016 13:29:22 -0700 From: Andrew Morton To: Anshuman Khandual Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, hughd@google.com, aneesh.kumar@linux.vnet.ibm.com, kirill@shutemov.name, n-horiguchi@ah.jp.nec.com, mgorman@techsingularity.net Subject: Re: [RFC 1/9] mm/hugetlb: Make GENERAL_HUGETLB functions PGD implementation aware Message-Id: <20160314132922.b2297b2b486416e4980741ee@linux-foundation.org> In-Reply-To: <56E23523.4020201@linux.vnet.ibm.com> References: <1457525450-4262-1-git-send-email-khandual@linux.vnet.ibm.com> <56E23523.4020201@linux.vnet.ibm.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 727 Lines: 15 On Fri, 11 Mar 2016 08:31:55 +0530 Anshuman Khandual wrote: > On 03/09/2016 05:40 PM, Anshuman Khandual wrote: > > Currently both the ARCH_WANT_GENERAL_HUGETLB functions 'huge_pte_alloc' > > and 'huge_pte_offset' dont take into account huge page implementation > > at the PGD level. With addition of PGD awareness into these functions, > > more architectures like POWER which also implements huge pages at PGD > > level (along with PMD level), can use ARCH_WANT_GENERAL_HUGETLB option. > > Hugh/Mel/Naoya/Andrew, > > Thoughts/inputs/suggestions ? Does this change looks okay ? Patches 1, 2 and 3 look OK to me. Please include them in the powerpc merge when the patchset is considered ready.