Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756129AbcCNUrW (ORCPT ); Mon, 14 Mar 2016 16:47:22 -0400 Received: from mail-sn1nam02on0080.outbound.protection.outlook.com ([104.47.36.80]:39776 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750741AbcCNUrU (ORCPT ); Mon, 14 Mar 2016 16:47:20 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; ettus.com; dkim=none (message not signed) header.d=none;ettus.com; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH 1/5] net: macb: Fix coding style error message To: Moritz Fischer , References: <1457896247-25934-1-git-send-email-moritz.fischer@ettus.com> <1457896247-25934-2-git-send-email-moritz.fischer@ettus.com> CC: , , , , , From: Michal Simek Message-ID: <56E72351.8020302@xilinx.com> Date: Mon, 14 Mar 2016 21:47:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1457896247-25934-2-git-send-email-moritz.fischer@ettus.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22192.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(24454002)(164054003)(189002)(36756003)(36386004)(33656002)(2906002)(50986999)(4326007)(54356999)(87936001)(5008740100001)(76176999)(64126003)(87266999)(230700001)(2950100001)(19580405001)(19580395003)(80316001)(189998001)(23746002)(77096005)(65816999)(65806001)(6806005)(4001350100001)(65956001)(63266004)(50466002)(83506001)(586003)(106466001)(5001770100001)(11100500001)(81166005)(86362001)(59896002)(1220700001)(1096002)(92566002)(47776003)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1NAM02HT239;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-MS-Office365-Filtering-Correlation-Id: 836349ef-2357-4d10-b3ee-08d34c49d511 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:SN1NAM02HT239; X-Microsoft-Antispam-PRVS: <0c03f755385243f89b6891ffc25f458e@SN1NAM02HT239.eop-nam02.prod.protection.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(8121501046)(5005006)(13023025)(13015025)(13017025)(13024025)(3002001)(10201501046);SRVR:SN1NAM02HT239;BCL:0;PCL:0;RULEID:;SRVR:SN1NAM02HT239; X-Forefront-PRVS: 0881A7A935 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2016 20:47:17.7277 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT239 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 900 Lines: 30 On 13.3.2016 20:10, Moritz Fischer wrote: > checkpatch.pl gave the following error: > > ERROR: space required before the open parenthesis '(' > + for(; p < end; p++, offset += 4) > > Signed-off-by: Moritz Fischer > --- > drivers/net/ethernet/cadence/macb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 50c9410..4370f37 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -496,7 +496,7 @@ static void macb_update_stats(struct macb *bp) > > WARN_ON((unsigned long)(end - p - 1) != (MACB_TPF - MACB_PFR) / 4); > > - for(; p < end; p++, offset += 4) > + for (; p < end; p++, offset += 4) > *p += bp->macb_reg_readl(bp, offset); > } > > Acked-by: Michal Simek Thanks, Michal