Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872AbcCNW2E (ORCPT ); Mon, 14 Mar 2016 18:28:04 -0400 Received: from mout.gmx.net ([212.227.17.21]:58878 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716AbcCNW2B (ORCPT ); Mon, 14 Mar 2016 18:28:01 -0400 Date: Mon, 14 Mar 2016 23:27:31 +0100 From: Sebastian Herbszt To: Arnd Bergmann Cc: martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com, James Smart , Dick Kennedy , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Hannes Reinecke , Sebastian Herbszt Subject: Re: [PATCH 2/3] lpfc: fix misleading indentation Message-ID: <20160314232731.0000404d@localhost> In-Reply-To: <1457965789-3373916-3-git-send-email-arnd@arndb.de> References: <1457965789-3373916-1-git-send-email-arnd@arndb.de> <1457965789-3373916-3-git-send-email-arnd@arndb.de> X-Mailer: Claws Mail 3.9.2-55-g74b05b (GTK+ 2.16.6; i586-pc-mingw32msvc) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:k2QnHnfZGagXqIAdZApSUNtMZcJuVeaMoI/HOkq57BewBcXJiDd xPjLQzgCJEX6Y/vADyPu6HXJtiwBjJn69vALxBj1BgFCSy5h6aaHwYKr+Hlq0pMG0uKBWK4 6Bs7+VTTqSB2HQWjlGbgzwjm0sB7apAC/2TIAROAOG3X88TQx5O1og6oGmUGJ1plbcYLw5Z aKN3iwmX/qcHzCEVFhTmw== X-UI-Out-Filterresults: notjunk:1;V01:K0:fZSlxWrHpfA=:OK9HFsa4sFkdX6VfxG04Y9 +hXiE50VpYOggmRwsgNpLoWZklIz4vy8jl9UxBsmy38pNOCuqD/A+Rj5evS/XCQuhf4dm3rFC faEYA3Kk2klx4YcMRptQSASTZs2KP17iz0dDxzkeLipc4th3CjRWb4Z+6jjVjPXgv1jHjoC3s MnWY1/a46LsKoil9uW7ryhHYJFbBh1A9aUhejKtLfPObXkxhKGx3YzX+mwqsA/X6QAI/xVNBN kTSJWfH8JFVcLP5w4D7sj8FgbNUefLEc7bFXuzQ1+b5JCmV01Qvca/k6i1bv4Eyp2xfsGS4Bh E5oaV4YUwdBmhijsTlKpz9gSQ2avJCKbi2KB3e1SmC8gj/h+XYZysoxkfszRYItTfEQEq7SVs AYDB+SVzC13l1mdK1ZtPsoNp0CJegq6ioRg2DnBA2DaUSh/BFrbP34LL8rB1beK0oineEkahQ UE4UYYTli3Ig5RU+RB4Az7TMeyFe3zLDMddVA5ARHLl4Fy9iQ7XdCj2OMKqvbVwYVa9PK8BYF Onah8Ucm/VF9gLcTTa7FDEzhY7U12VJTIMO5jL6+UhkQnMspoD1Y3HP2bACbOndnLsLB9vXxB dl5/vtqB6Nsdc1N6Ip03vS9DHKOtH7AYsMC6VwcLjaIw3me/16uCM6Acsi33MWeyebrllXmc4 YBwk2961vMhgPG6StHf0E4B8cdWyJF3O6UGeHlhkUNG3LzZKRHGSUPgdFRMdCMFcjcecLUNTr kJ4IkmnyOIjgOHYABeaOjL51dtdMvAWGIX+bHVFK+FaTEfuC1kPneiaQNLgJY9W4O2nfa444x p5iEm8W Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 26 Arnd Bergmann wrote: > gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array() > call in lpfc_online(), which clearly doesn't look right: > > drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online': > drivers/scsi/lpfc/lpfc_init.c:2880:3: warning: statement is indented as if it were guarded by... [-Wmisleading-indentation] > lpfc_destroy_vport_work_array(phba, vports); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/scsi/lpfc/lpfc_init.c:2863:2: note: ...this 'if' clause, but it is not > if (vports != NULL) > ^~ > > Looking at the patch that introduced this code, it's clear that the > behavior is correct and the indentation is wrong. > > This fixes the indentation and adds curly braces around the previous > if() block for clarity, as that is most likely what caused the code > to be misindented in the first place. > > Signed-off-by: Arnd Bergmann > Fixes: 549e55cd2a1b ("[SCSI] lpfc 8.2.2 : Fix locking around HBA's port_list") > --- > drivers/scsi/lpfc/lpfc_init.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Sebastian Herbszt