Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934237AbcCOHiA (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Mar 2016 03:38:00 -0400
Received: from szxga02-in.huawei.com ([119.145.14.65]:56657 "EHLO
	szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932156AbcCOHhx (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Mar 2016 03:37:53 -0400
Subject: Re: [PATCH v2 1/2] Irq/mbigen:Change the mbigen node definition in dt
 binding file
To: Thomas Gleixner <tglx@linutronix.de>
References: <1457937907-14008-1-git-send-email-majun258@huawei.com>
 <1457937907-14008-2-git-send-email-majun258@huawei.com>
 <alpine.DEB.2.11.1603140844490.3657@nanos>
CC: <Catalin.Marinas@arm.com>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <Will.Deacon@arm.com>,
        <mark.rutland@arm.com>, <marc.zyngier@arm.com>, <jason@lakedaemon.net>,
        <lizefan@huawei.com>, <huxinwei@huawei.com>, <dingtianhong@huawei.com>,
        <liguozhu@hisilicon.com>, <guohanjun@huawei.com>,
        <zhaojunhua@hisilicon.com>
From: "majun (F)" <majun258@huawei.com>
Message-ID: <56E7BB53.3060705@huawei.com>
Date: Tue, 15 Mar 2016 15:35:47 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.11.1603140844490.3657@nanos>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.177.235.245]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020203.56E7BB63.01E9,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: eb1ba90490e2acfbb8723706e8f29279
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1280
Lines: 51

Hi Thomas:
	Thanks for pointing out the problems.
I'll make detail description about this problem and resend this patch set.


在 2016/3/14 15:49, Thomas Gleixner 写道:
> Majun,
> 
> On Mon, 14 Mar 2016, MaJun wrote:
> 
> First of all the prefix for irq chip drivers is not "Irq/".
> 
> Hint: git log drivers/irqchip 
> 
>> From: Ma Jun <majun258@huawei.com>
>>
>> For mbigen module, there is a special case that more than one mbigen
>> device nodes use the same reg definition in DTS when these devices
>> exist in the same mbigen hardware module.
> 
> There is a special case, so what?
>  

In current driver, the registers would be remapped repeatedly
and caused error when use the function "devm_ioremap_resource".

That's the problem I tried to fix.

>> To fix the mbigen IO remap problem, the mbigen node definition and
> 
> Which problem?
> 
>> structure are changed based on Mark Rutland's suggestion.
> 
> That's really uselss. Nobody has any idea what Mark suggested and in which way
> it fixes that unspecified problem you are talking about.
> 

Actually, I discussed this problem with Mark in v1.
He raised some questions and suggestions
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/403691.html

Thanks!
MaJun

> Thanks,
> 
> 	tglx
> 
> .
>