Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755808AbcCOILD (ORCPT ); Tue, 15 Mar 2016 04:11:03 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:49135 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933002AbcCOIKZ (ORCPT ); Tue, 15 Mar 2016 04:10:25 -0400 Subject: Re: [PATCH v2 4/5] mmc: davinci: don't use dma platform resources To: David Lechner References: <56E6BF7E.7020401@ti.com> <1457996081-21975-1-git-send-email-david@lechnology.com> <1457996081-21975-5-git-send-email-david@lechnology.com> CC: , , , , , Peter Ujfalusi From: Sekhar Nori Message-ID: <56E7C321.5060405@ti.com> Date: Tue, 15 Mar 2016 13:39:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1457996081-21975-5-git-send-email-david@lechnology.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2299 Lines: 74 + Peter On Tuesday 15 March 2016 04:24 AM, David Lechner wrote: > The davinci arch now has dma_slave_map tables for dma resources, so it is > no longer necessary to pass dma resources through the platform device. > > Signed-off-by: David Lechner Looks good to me. Acked-by: Sekhar Nori Thanks, Sekhar > --- > > v2 changes: Remove platform_get_resource completly instead of just ignoring it. > > > drivers/mmc/host/davinci_mmc.c | 19 ++----------------- > 1 file changed, 2 insertions(+), 17 deletions(-) > > diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c > index 8d10a92..dc96401 100644 > --- a/drivers/mmc/host/davinci_mmc.c > +++ b/drivers/mmc/host/davinci_mmc.c > @@ -202,7 +202,6 @@ struct mmc_davinci_host { > u32 buffer_bytes_left; > u32 bytes_left; > > - u32 rxdma, txdma; > struct dma_chan *dma_tx; > struct dma_chan *dma_rx; > bool use_dma; > @@ -520,16 +519,14 @@ static int __init davinci_acquire_dma_channels(struct mmc_davinci_host *host) > dma_cap_set(DMA_SLAVE, mask); > > host->dma_tx = > - dma_request_slave_channel_compat(mask, edma_filter_fn, > - &host->txdma, mmc_dev(host->mmc), "tx"); > + dma_request_slave_channel(mmc_dev(host->mmc), "tx"); > if (!host->dma_tx) { > dev_err(mmc_dev(host->mmc), "Can't get dma_tx channel\n"); > return -ENODEV; > } > > host->dma_rx = > - dma_request_slave_channel_compat(mask, edma_filter_fn, > - &host->rxdma, mmc_dev(host->mmc), "rx"); > + dma_request_slave_channel(mmc_dev(host->mmc), "rx"); > if (!host->dma_rx) { > dev_err(mmc_dev(host->mmc), "Can't get dma_rx channel\n"); > r = -ENODEV; > @@ -1251,18 +1248,6 @@ static int __init davinci_mmcsd_probe(struct platform_device *pdev) > host = mmc_priv(mmc); > host->mmc = mmc; /* Important */ > > - r = platform_get_resource(pdev, IORESOURCE_DMA, 0); > - if (!r) > - dev_warn(&pdev->dev, "RX DMA resource not specified\n"); > - else > - host->rxdma = r->start; > - > - r = platform_get_resource(pdev, IORESOURCE_DMA, 1); > - if (!r) > - dev_warn(&pdev->dev, "TX DMA resource not specified\n"); > - else > - host->txdma = r->start; > - > host->mem_res = mem; > host->base = devm_ioremap(&pdev->dev, mem->start, mem_size); > if (!host->base) >