Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934166AbcCOIOK (ORCPT ); Tue, 15 Mar 2016 04:14:10 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:18695 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753870AbcCOIOH convert rfc822-to-8bit (ORCPT ); Tue, 15 Mar 2016 04:14:07 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 15 Mar 2016 01:12:39 -0700 Message-ID: <56E7C457.5000301@nvidia.com> Date: Tue, 15 Mar 2016 16:14:15 +0800 From: Wei Ni User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Eduardo Valentin CC: , , , , , , , Subject: Re: [PATCH V7 08/12] of: add notes of critical trips for soctherm References: <1457665860-30003-1-git-send-email-wni@nvidia.com> <20160314210027.GA4740@localhost.localdomain> <56E7BE87.405@nvidia.com> In-Reply-To: <56E7BE87.405@nvidia.com> X-Originating-IP: [10.19.224.146] X-ClientProxiedBy: HKMAIL102.nvidia.com (10.18.16.11) To HKMAIL101.nvidia.com (10.18.16.10) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1121 Lines: 36 On 2016年03月15日 15:49, Wei Ni wrote: > > > On 2016年03月15日 05:00, Eduardo Valentin wrote: >> * PGP Signed by an unknown key >> >> On Fri, Mar 11, 2016 at 11:11:00AM +0800, Wei Ni wrote: >>> The "critical" type trip in thermal zone can be >>> set to SOC_THERM hardware, it can trigger shut down >>> or reset event from hardware. >>> >>> Signed-off-by: Wei Ni >>> Acked-by: Rob Herring >>> --- >>> Documentation/devicetree/bindings/thermal/tegra-soctherm.txt | 12 ++++++++++++ >>> 1 file changed, 12 insertions(+) >> >> I did not see in your patch set an update on the compatible string for >> the new chip. Did I miss something? > > As I said in the previous [00/12], the "commit 193c9d23a0f0" already added the > compatible string. At that time, it just used current tegra_soctherm.c driver to > support Tegra210, it can work, but can't show temperatures correctly. Oh, sorry, I made a mistake, this "commit 193c9d23a0f0" just added the compatible string, did not use current tegra_soctherm driver to support Tegra210. Wei. > >> >> * Unknown Key >> * 0x7DA4E256 >>