Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965113AbcCOIyw (ORCPT ); Tue, 15 Mar 2016 04:54:52 -0400 Received: from smtprelay0048.hostedemail.com ([216.40.44.48]:59438 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933944AbcCOIym (ORCPT ); Tue, 15 Mar 2016 04:54:42 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:960:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1537:1561:1593:1594:1711:1714:1730:1747:1777:1792:2110:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3868:4321:5007:6261:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13311:13357:13439:14659:21080:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: blade56_b4ce2d76bb37 X-Filterd-Recvd-Size: 1340 Message-ID: <1458032076.11972.179.camel@perches.com> Subject: Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND From: Joe Perches To: Dan Carpenter Cc: Dmitry Torokhov , Andrew Duggan , Henrik Rydberg , Christopher Heiny , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Tue, 15 Mar 2016 01:54:36 -0700 In-Reply-To: <20160315083754.GA30221@mwanda> References: <20160315071140.GF13560@mwanda> <1458030809.11972.178.camel@perches.com> <20160315083754.GA30221@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 265 Lines: 9 On Tue, 2016-03-15 at 11:37 +0300, Dan Carpenter wrote: > On Tue, Mar 15, 2016 at 01:33:29AM -0700, Joe Perches wrote: > > > > Right and as well these are bool so the !! isn't necessary. > Not necessary but nice for reading... opinions vary. cheers, Joe