Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965117AbcCOJKR (ORCPT ); Tue, 15 Mar 2016 05:10:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:37840 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752435AbcCOJKK (ORCPT ); Tue, 15 Mar 2016 05:10:10 -0400 Date: Tue, 15 Mar 2016 10:10:08 +0100 From: Petr Mladek To: Jessica Yu Cc: Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Miroslav Benes , Rusty Russell , Steven Rostedt , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: livepatch/module: remove livepatch module notifier Message-ID: <20160315091008.GK22171@pathway.suse.cz> References: <1457726628-9171-1-git-send-email-jeyu@redhat.com> <1457726628-9171-3-git-send-email-jeyu@redhat.com> <20160314150643.GU10940@pathway.suse.cz> <20160314175008.GA1180@packer-debian-8-amd64.digitalocean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160314175008.GA1180@packer-debian-8-amd64.digitalocean.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 24 On Mon 2016-03-14 13:50:09, Jessica Yu wrote: > +++ Petr Mladek [14/03/16 16:06 +0100]: > >On Fri 2016-03-11 15:03:48, Jessica Yu wrote: > >>+err: > >>+ /* > >>+ * If a patch is unsuccessfully applied, return > >>+ * error to the module loader. > >>+ */ > >>+ pr_warn("patch '%s' failed for module '%s', refusing to load module '%s'\n", > >>+ patch->mod->name, obj->mod->name, obj->mod->name); > > > >One more thing. We should add here: > > > > mod->klp_alive = true; > > > >Otherwise, there is a small race window when a new patch will try to > >patch the module. > > Ah, you are right. I think you meant false, though :-) Will fix that. Yeah, I meant false :-) Thanks, Petr