Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934636AbcCOKSb (ORCPT ); Tue, 15 Mar 2016 06:18:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50123 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932225AbcCOKSW (ORCPT ); Tue, 15 Mar 2016 06:18:22 -0400 From: Benjamin Tissoires To: Dmitry Torokhov , Andrew Duggan , linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] Input: synaptics - handle spurious release of trackstick buttons, again Date: Tue, 15 Mar 2016 11:18:17 +0100 Message-Id: <1458037097-6444-1-git-send-email-benjamin.tissoires@redhat.com> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 15 Mar 2016 10:18:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 28 Looks like the fimware 8.2 stall has the extra buttons spurious release bug. Link: https://bugzilla.kernel.org/show_bug.cgi?id=114321 Cc: stable@vger.kernel.org Signed-off-by: Benjamin Tissoires --- drivers/input/mouse/synaptics.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 6025eb4..9f3b83f 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c @@ -862,8 +862,9 @@ static void synaptics_report_ext_buttons(struct psmouse *psmouse, if (!SYN_CAP_MULTI_BUTTON_NO(priv->ext_cap)) return; - /* Bug in FW 8.1, buttons are reported only when ExtBit is 1 */ - if (SYN_ID_FULL(priv->identity) == 0x801 && + /* Bug in FW 8.1 & 8.2, buttons are reported only when ExtBit is 1 */ + if (((SYN_ID_FULL(priv->identity) == 0x801) || + (SYN_ID_FULL(priv->identity) == 0x802)) && !((psmouse->packet[0] ^ psmouse->packet[3]) & 0x02)) return; -- 2.5.0