Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933429AbcCOLio (ORCPT ); Tue, 15 Mar 2016 07:38:44 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:55327 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932428AbcCOLig convert rfc822-to-8bit (ORCPT ); Tue, 15 Mar 2016 07:38:36 -0400 From: Vineet Gupta To: Andreas Ziegler , Bjorn Helgaas CC: "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Joao Pinto Subject: Re: [PATCH] ARC: Don't source drivers/pci/pcie/Kconfig ourselves Thread-Topic: [PATCH] ARC: Don't source drivers/pci/pcie/Kconfig ourselves Thread-Index: AQHRfqw052fwdxzR40etGDN655w4fg== Date: Tue, 15 Mar 2016 11:38:34 +0000 Message-ID: References: <1458040615-10697-1-git-send-email-andreas.ziegler@fau.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.144.199.104] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1488 Lines: 42 On Tuesday 15 March 2016 04:47 PM, Andreas Ziegler wrote: > Commit 5f8fc43217a0 ("PCI: Include pci/pcie/Kconfig directly from > pci/Kconfig") in linux-next changed drivers/pci/Kconfig to include > drivers/pci/pcie/Kconfig itself, so that architectures do not need > to source both files themselves. ARC just recently gained PCI support > through commit 6b3fb77998dd ("ARC: Add PCI support"), but this change > was based on the old behaviour of the Kconfig files. This makes > Kconfig now spit out the following warnings: > > drivers/pci/pcie/Kconfig:61:warning: choice value used outside its choice group > drivers/pci/pcie/Kconfig:67:warning: choice value used outside its choice group > drivers/pci/pcie/Kconfig:74:warning: choice value used outside its choice group > > This change updates the Kconfig file for ARC, dropping the now > unnecessary 'source' statement, which makes the warning disappear. > > Signed-off-by: Andreas Ziegler Thx for the fix Andreas. @Bjorn sorry you might to have to pick this one up as well. If not, that's fine too - I'll queue it up once ARC PCI hits upstream. Thx, -Vineet > --- > arch/arc/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig > index 69d05f5..282efec 100644 > --- a/arch/arc/Kconfig > +++ b/arch/arc/Kconfig > @@ -592,7 +592,6 @@ config PCI_SYSCALL > def_bool PCI > > source "drivers/pci/Kconfig" > -source "drivers/pci/pcie/Kconfig" > > endmenu >