Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934759AbcCOM21 (ORCPT ); Tue, 15 Mar 2016 08:28:27 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:49440 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932135AbcCOM2S (ORCPT ); Tue, 15 Mar 2016 08:28:18 -0400 Subject: Re: [PATCH 13/13] thermal: convert ti-thermal to use devm_thermal_zone_of_sensor_register To: Eduardo Valentin , Rui Zhang References: <1457559336-17652-1-git-send-email-edubezval@gmail.com> <1457559336-17652-15-git-send-email-edubezval@gmail.com> CC: Linux PM , LKML , , From: Keerthy Message-ID: <56E7FF8E.8030209@ti.com> Date: Tue, 15 Mar 2016 17:56:54 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1457559336-17652-15-git-send-email-edubezval@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1680 Lines: 47 Hi Eduardo, On Thursday 10 March 2016 03:05 AM, Eduardo Valentin wrote: > This changes the driver to use the devm_ version > of thermal_zone_of_sensor_register and cleans > up the local points and unregister calls. > Boot tested on dra7xx-evm, dra72x-evm, pandaboard-es. Also checked the thermal sysfs entries on am57xx-beagle-x15. Tested-by: Keerthy > Cc: Zhang Rui > Cc: linux-pm@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Eduardo Valentin > --- > drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > index b213a12..15c0a9a 100644 > --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c > @@ -337,7 +337,7 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id, > return -EINVAL; > > /* in case this is specified by DT */ > - data->ti_thermal = thermal_zone_of_sensor_register(bgp->dev, id, > + data->ti_thermal = devm_thermal_zone_of_sensor_register(bgp->dev, id, > data, &ti_of_thermal_ops); > if (IS_ERR(data->ti_thermal)) { > /* Create thermal zone */ > @@ -368,9 +368,6 @@ int ti_thermal_remove_sensor(struct ti_bandgap *bgp, int id) > if (data && data->ti_thermal) { > if (data->our_zone) > thermal_zone_device_unregister(data->ti_thermal); > - else > - thermal_zone_of_sensor_unregister(bgp->dev, > - data->ti_thermal); > } > > return 0; >