Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755808AbcCOOxf (ORCPT ); Tue, 15 Mar 2016 10:53:35 -0400 Received: from skprod3.natinst.com ([130.164.80.24]:36319 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751787AbcCOOxb (ORCPT ); Tue, 15 Mar 2016 10:53:31 -0400 Date: Tue, 15 Mar 2016 09:53:27 -0500 From: Josh Cartwright To: Kyle Roeschley Cc: gregkh@linuxfoundation.org, arnd@arndb.de, linux-kernel@vger.kernel.org, jeff.westfahl@ni.com, nathan.sullivan@ni.com, xander.huff@ni.com, aaron.rossetto@ni.com, gratian.crisan@ni.com Subject: Re: [PATCH 2/2] misc: nirtfeatures: physical interface elements Message-ID: <20160315145327.GD27081@jcartwri.amer.corp.natinst.com> References: <1457992508-18745-1-git-send-email-kyle.roeschley@ni.com> MIME-Version: 1.0 In-Reply-To: <1457992508-18745-1-git-send-email-kyle.roeschley@ni.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 03/15/2016 09:53:27 AM, Serialize by Router on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 03/15/2016 09:53:28 AM, Serialize complete at 03/15/2016 09:53:28 AM Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VV4b6MQE+OnNyhkM" Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-03-15_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1739 Lines: 50 --VV4b6MQE+OnNyhkM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey Kyle- On Mon, Mar 14, 2016 at 04:55:08PM -0500, Kyle Roeschley wrote: > From: Gratian Crisan =46rom what I understand, this was mostly Aaron's work, so he should get authorship. I could be wrong, though, but you'll want to check. > These changes add support for PIEs (physical interface elements), which > are defined as physical elements fixed to a controller/chassis with > which a user can interact (e.g. LEDs and switches) and whose meaning > is user-defined and implementation-specific. [..] > --- > drivers/misc/nirtfeatures.c | 753 ++++++++++++++++++++++++++++++++++++++= ++---- > 1 file changed, 694 insertions(+), 59 deletions(-) This patchset is awkwardly split up, especially because you are removing what you are adding in the first patch. I would suggest coming up with a better patch breakdown that doesn't do this, to make it easier on reviewers. Perhaps, breaking it up into a patchset where each patch implements a different class of functionality (leds, input). Josh --VV4b6MQE+OnNyhkM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJW6CHjAAoJEKp7ZBKwQFAreMAH+wUyqYjfKuOoquvDN4Hp+C0q DBu+5YPLWyaGQjwytEQgsUfyBVgVLoPFNZSLxToARX4zXxeRvPbpPinCnu/Y6dUB 5Vvl2ofEX2oZV6NbDvM93A0N7uk02RVz3muyFZTO46I7DAUtX4Dd9AZWi1e6P6AP WmP1ZY8f0QDR+PsBKx1LVMXkVioxQ+LCkCuzbbKuSmjYmC2tnLFzU78OQwCHUVfj 8uESYhc6jjIXefPaZ1Xrmco5FgCwx1KqsirHfon11CnMALi+MNWR82lob/6dJL79 tTq2Zrj4CuO6D/KSzsbrphYoxSoPPnKIjyRmameHHQFHVCpmkamsRORuLbGww9M= =6+XR -----END PGP SIGNATURE----- --VV4b6MQE+OnNyhkM--