Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934571AbcCOP2D (ORCPT ); Tue, 15 Mar 2016 11:28:03 -0400 Received: from mail-io0-f169.google.com ([209.85.223.169]:36199 "EHLO mail-io0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755137AbcCOP17 (ORCPT ); Tue, 15 Mar 2016 11:27:59 -0400 MIME-Version: 1.0 In-Reply-To: <1457998330-8070-1-git-send-email-nicolassaenzj@gmail.com> References: <1457998330-8070-1-git-send-email-nicolassaenzj@gmail.com> Date: Tue, 15 Mar 2016 16:27:55 +0100 X-Google-Sender-Auth: 7NADLUmQaCCB3HknYMwRzV-MXmQ Message-ID: Subject: Re: [PATCH] gpio: 74x164: add dt support for nxp's 74x594 From: Geert Uytterhoeven To: Nicolas Saenz Julienne Cc: Linus Walleij , Alexandre Courbot , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1510 Lines: 40 On Tue, Mar 15, 2016 at 12:32 AM, Nicolas Saenz Julienne wrote: > The chip is also an 8 bit shift register which works out of the box as a GPO > expander with this patch > > Signed-off-by: Nicolas Saenz Julienne > --- > Documentation/devicetree/bindings/gpio/gpio-74x164.txt | 4 +++- > drivers/gpio/gpio-74x164.c | 1 + > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-74x164.txt b/Documentation/devicetree/bindings/gpio/gpio-74x164.txt > index cc26080..ce1b223 100644 > --- a/Documentation/devicetree/bindings/gpio/gpio-74x164.txt > +++ b/Documentation/devicetree/bindings/gpio/gpio-74x164.txt > @@ -1,7 +1,9 @@ > * Generic 8-bits shift register GPIO driver > > Required properties: > -- compatible : Should be "fairchild,74hc595" > +- compatible: Should contain one of the following: > + "fairchild,74hc595" > + "nxp,74lvc594" Why did you choose the "lvc" variant? Ideally, you want to put the oldest "manuf,74x594" variant here. I once read it was Motorola who invented the 7459x parts, to interface with SPI. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds